search

devicekit / DeviceKit

DeviceKit is a value-type replacement of UIDevice.
MIT License
4.42k stars 428 forks source link

Added support for arm64 simulator #273

Closed FelixLisczyk closed 3 years ago

FelixLisczyk commented 3 years ago

This PR adds support for the Xcode simulator on Apple Silicon Macs.

DeviceKit currently returns

(lldb) po Device.current.realDevice
▿ arm64
  - unknown : "arm64"

on these Macs.

devicekit-danger-bot commented 3 years ago
13 Warnings
:warning: Plist changed, don’t forget to localize your plist values
:warning: Source/Device.generated.swift#L151 - TODOs should be resolved ()).
:warning: Source/Device.generated.swift#L153 - TODOs should be resolved ()).
:warning: Source/Device.generated.swift#L155 - TODOs should be resolved ()).
:warning: Source/Device.generated.swift#L157 - TODOs should be resolved ()).
:warning: Source/Device.generated.swift#L159 - TODOs should be resolved ()).
:warning: Source/Device.generated.swift#L161 - TODOs should be resolved ()).
:warning: Source/Device.generated.swift#L163 - TODOs should be resolved ()).
:warning: Source/Device.generated.swift#L165 - TODOs should be resolved ()).
:warning: Source/Device.generated.swift#L207 - TODOs should be resolved ()).
:warning: Source/Device.generated.swift#L209 - TODOs should be resolved ()).
:warning: Source/Device.generated.swift#L760 - Prefer non-optional booleans over optional booleans.
:warning: Source/Device.generated.swift#L1495 - Prefer empty collection over optional collection.

SwiftLint found issues

Warnings

File Line Reason
Device.generated.swift 760 Prefer non-optional booleans over optional booleans.
Device.generated.swift 1495 Prefer empty collection over optional collection.
Device.generated.swift 151 TODOs should be resolved ()).
Device.generated.swift 153 TODOs should be resolved ()).
Device.generated.swift 155 TODOs should be resolved ()).
Device.generated.swift 157 TODOs should be resolved ()).
Device.generated.swift 159 TODOs should be resolved ()).
Device.generated.swift 161 TODOs should be resolved ()).
Device.generated.swift 163 TODOs should be resolved ()).
Device.generated.swift 165 TODOs should be resolved ()).
Device.generated.swift 207 TODOs should be resolved ()).
Device.generated.swift 209 TODOs should be resolved ()).

Generated by :no_entry_sign: Danger

denisenepraunig commented 3 years ago

Hi Felix, sorry that you didn't hear back from us. First of all, thank you for your PR! I wanted to test this with a M1 from a former colleague but we didn't have a chance to meet yet and I don't own any M1 devices... Let's see how we can go forward.

FelixLisczyk commented 3 years ago

Sure, please let me know if I can help.

mrgrauel commented 3 years ago

@denisenepraunig It would be great if this was published 🎉

Kaspik commented 3 years ago

Please, please @denisenepraunig - merge this so we can get unblocked! 🚀

denisenepraunig commented 3 years ago

Thank you @FelixII for your contribution! Sorry that it took quite some time 🙈.