Closed Zandor300 closed 3 years ago
3 Warnings | |
---|---|
:warning: | Plist changed, don’t forget to localize your plist values |
:warning: | Source/Device.generated.swift#L779 - Prefer non-optional booleans over optional booleans. |
:warning: | Source/Device.generated.swift#L1522 - Prefer empty collection over optional collection. |
File | Line | Reason |
---|---|---|
Device.generated.swift | 779 | Prefer non-optional booleans over optional booleans. |
Device.generated.swift | 1522 | Prefer empty collection over optional collection. |
Device.generated.swift | 263 | TODOs should be resolved ()). |
Device.generated.swift | 265 | TODOs should be resolved ()). |
Device.generated.swift | 267 | TODOs should be resolved ()). |
Device.generated.swift | 269 | TODOs should be resolved ()). |
Device.generated.swift | 284 | TODOs should be resolved ()). |
Device.generated.swift | 286 | TODOs should be resolved ()). |
Generated by :no_entry_sign: Danger
How is this coming along?
@gabors We're still waiting on device identifiers, support pages and support images. If Apple is slow again with the support pages and images, we could release early without this, but identifiers are important for detecting the current device.
@gabors We're still waiting on device identifiers, support pages and support images. If Apple is slow again with the support pages and images, we could release early without this, but identifiers are important for detecting the current device.
Great thanks! I was also noticing that the Apple TV 4K gen2 Simulator was not being detected as a simulator (AppleTV11,1) but that's likely also because you don't yet have that identifier in the framework.
`(lldb) po ProcessInfo().environment["SIMULATOR_MODEL_IDENTIFIER"]
▿ Optional
@denisenepraunig I would say let's merge this and release 4.4.0. Then we can release a 4.4.1 when Apple eventually publishes the support pages.
Yeah totally agree here. I think our users would need the DeviceIdentifiers first and foremost, then support pages and alike.
Add support for the devices announced at the April 2021 Apple Event:
TODO