devicekit / DeviceKit

DeviceKit is a value-type replacement of UIDevice.
MIT License
4.42k stars 428 forks source link

Add support for new September 14th 2021 devices. #286

Closed Zandor300 closed 2 years ago

Zandor300 commented 2 years ago

Required

Optional

insightmind commented 2 years ago

According to the device support files in Xcode 13 RC

Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Library/Developer/CoreSimulator/Profiles/DeviceTypes

these are the device identifiers:

Device Identifier
iPhone 13 mini iPhone14,4
iPhone 13 Pro Max iPhone14,3
iPhone 13 Pro iPhone14,2
iPhone 13 iPhone14,5
iPad mini (6th generation) iPad14,1
iPad (9th generation) iPad12,2

Although not necessarily relevant for this PR the device identifiers for Apple Watch Series 7

Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Library/Developer/CoreSimulator/Profiles/DeviceTypes
Device Identifier
Apple Watch Series 7 - 41mm Watch6,6
Apple Watch Series 7 - 45mm Watch6,9

This is probably an incomplete list of all actually available device identifiers.

Zandor300 commented 2 years ago

@insightmind Thanks!

github-actions[bot] commented 2 years ago
56 Warnings
:warning: Plist changed, don't forget to localize your plist values
:warning: Source/Device.generated.swift#L287 - TODOs should be resolved ()).
todo Device.generated.swift:287
:warning: Source/Device.generated.swift#L289 - TODOs should be resolved ()).
todo Device.generated.swift:289
:warning: Source/Device.generated.swift#L291 - TODOs should be resolved ()).
todo Device.generated.swift:291
:warning: Source/Device.generated.swift#L293 - TODOs should be resolved ()).
todo Device.generated.swift:293
:warning: Source/Device.generated.swift#L308 - TODOs should be resolved ()).
todo Device.generated.swift:308
:warning: Source/Device.generated.swift#L310 - TODOs should be resolved ()).
todo Device.generated.swift:310
:warning: Source/Device.generated.swift#L391 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:391
:warning: Source/Device.generated.swift#L720 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:720
:warning: Source/Device.generated.swift#L756 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:756
:warning: Source/Device.generated.swift#L761 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:761
:warning: Source/Device.generated.swift#L766 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:766
:warning: Source/Device.generated.swift#L771 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:771
:warning: Source/Device.generated.swift#L777 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:777
:warning: Source/Device.generated.swift#L782 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:782
:warning: Source/Device.generated.swift#L787 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:787
:warning: Source/Device.generated.swift#L792 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:792
:warning: Source/Device.generated.swift#L797 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:797
:warning: Source/Device.generated.swift#L804 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:804
:warning: Source/Device.generated.swift#L812 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:812
:warning: Source/Device.generated.swift#L818 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:818
:warning: Source/Device.generated.swift#L821 - Prefer non-optional booleans over optional booleans.
discouraged_optional_boolean Device.generated.swift:821
:warning: Source/Device.generated.swift#L822 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:822
:warning: Source/Device.generated.swift#L827 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:827
:warning: Source/Device.generated.swift#L848 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:848
:warning: Source/Device.generated.swift#L853 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:853
:warning: Source/Device.generated.swift#L858 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:858
:warning: Source/Device.generated.swift#L868 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:868
:warning: Source/Device.generated.swift#L873 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:873
:warning: Source/Device.generated.swift#L883 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:883
:warning: Source/Device.generated.swift#L888 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:888
:warning: Source/Device.generated.swift#L893 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:893
:warning: Source/Device.generated.swift#L903 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:903
:warning: Source/Device.generated.swift#L913 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:913
:warning: Source/Device.generated.swift#L918 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:918
:warning: Source/Device.generated.swift#L923 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:923
:warning: Source/Device.generated.swift#L928 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:928
:warning: Source/Device.generated.swift#L933 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:933
:warning: Source/Device.generated.swift#L938 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:938
:warning: Source/Device.generated.swift#L943 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:943
:warning: Source/Device.generated.swift#L960 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:960
:warning: Source/Device.generated.swift#L993 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:993
:warning: Source/Device.generated.swift#L1000 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:1000
:warning: Source/Device.generated.swift#L1391 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:1391
:warning: Source/Device.generated.swift#L1453 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:1453
:warning: Source/Device.generated.swift#L1503 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:1503
:warning: Source/Device.generated.swift#L1560 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:1560
:warning: Source/Device.generated.swift#L1565 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:1565
:warning: Source/Device.generated.swift#L1571 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:1571
:warning: Source/Device.generated.swift#L1582 - Prefer empty collection over optional collection.
discouraged_optional_collection Device.generated.swift:1582
:warning: Source/Device.generated.swift#L1748 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:1748
:warning: Source/Device.generated.swift#L1768 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:1768
:warning: Source/Device.generated.swift#L1774 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:1774
:warning: Source/Device.generated.swift#L1779 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:1779
:warning: Source/Device.generated.swift#L1784 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:1784
:warning: Source/Device.generated.swift#L1789 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:1789

SwiftLint found issues

Warnings

File Line Reason
Device.generated.swift 821 Prefer non-optional booleans over optional booleans. (discouraged_optional_boolean)
Device.generated.swift 1582 Prefer empty collection over optional collection. (discouraged_optional_collection)
Device.generated.swift 391 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 720 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 725 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 730 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 736 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 741 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 746 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 751 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 756 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 761 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 766 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 771 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 777 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 782 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 787 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 792 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 797 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 804 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 812 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 818 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 822 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 827 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 833 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 838 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 843 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 848 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 853 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 858 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 863 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 868 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 873 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 878 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 883 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 888 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 893 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 898 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 903 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 908 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 913 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 918 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 923 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 928 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 933 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 938 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 943 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 960 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 993 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 1000 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 1391 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 1453 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 1503 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 1560 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 1565 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 1571 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 1628 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 1742 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 1748 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 1753 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 1758 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 1763 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 1768 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 1774 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 1779 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 1784 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 1789 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 167 TODOs should be resolved ()). (todo)
Device.generated.swift 169 TODOs should be resolved ()). (todo)
Device.generated.swift 171 TODOs should be resolved ()). (todo)
Device.generated.swift 173 TODOs should be resolved ()). (todo)
Device.generated.swift 175 TODOs should be resolved ()). (todo)
Device.generated.swift 177 TODOs should be resolved ()). (todo)
Device.generated.swift 179 TODOs should be resolved ()). (todo)
Device.generated.swift 181 TODOs should be resolved ()). (todo)
Device.generated.swift 223 TODOs should be resolved ()). (todo)
Device.generated.swift 225 TODOs should be resolved ()). (todo)
Device.generated.swift 251 TODOs should be resolved ()). (todo)
Device.generated.swift 253 TODOs should be resolved ()). (todo)
Device.generated.swift 287 TODOs should be resolved ()). (todo)
Device.generated.swift 289 TODOs should be resolved ()). (todo)
Device.generated.swift 291 TODOs should be resolved ()). (todo)
Device.generated.swift 293 TODOs should be resolved ()). (todo)
Device.generated.swift 308 TODOs should be resolved ()). (todo)
Device.generated.swift 310 TODOs should be resolved ()). (todo)

Generated by :no_entry_sign: Danger