Closed denisenepraunig closed 2 years ago
75 Warnings | |
---|---|
:warning: | Plist changed, don't forget to localize your plist values |
:warning: | Source/Device.generated.swift#L263 - TODOs should be resolved ()).todo Device.generated.swift:263 |
:warning: | Source/Device.generated.swift#L265 - TODOs should be resolved ()).todo Device.generated.swift:265 |
:warning: | Source/Device.generated.swift#L267 - TODOs should be resolved ()).todo Device.generated.swift:267 |
:warning: | Source/Device.generated.swift#L269 - TODOs should be resolved ()).todo Device.generated.swift:269 |
:warning: | Source/Device.generated.swift#L284 - TODOs should be resolved ()).todo Device.generated.swift:284 |
:warning: | Source/Device.generated.swift#L286 - TODOs should be resolved ()).todo Device.generated.swift:286 |
:warning: | Source/Device.generated.swift#L367 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:367 |
:warning: | Source/Device.generated.swift#L678 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:678 |
:warning: | Source/Device.generated.swift#L683 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:683 |
:warning: | Source/Device.generated.swift#L688 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:688 |
:warning: | Source/Device.generated.swift#L694 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:694 |
:warning: | Source/Device.generated.swift#L699 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:699 |
:warning: | Source/Device.generated.swift#L704 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:704 |
:warning: | Source/Device.generated.swift#L709 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:709 |
:warning: | Source/Device.generated.swift#L714 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:714 |
:warning: | Source/Device.generated.swift#L719 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:719 |
:warning: | Source/Device.generated.swift#L724 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:724 |
:warning: | Source/Device.generated.swift#L729 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:729 |
:warning: | Source/Device.generated.swift#L735 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:735 |
:warning: | Source/Device.generated.swift#L740 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:740 |
:warning: | Source/Device.generated.swift#L745 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:745 |
:warning: | Source/Device.generated.swift#L750 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:750 |
:warning: | Source/Device.generated.swift#L755 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:755 |
:warning: | Source/Device.generated.swift#L762 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:762 |
:warning: | Source/Device.generated.swift#L770 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:770 |
:warning: | Source/Device.generated.swift#L776 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:776 |
:warning: | Source/Device.generated.swift#L779 - Prefer non-optional booleans over optional booleans.discouraged_optional_boolean Device.generated.swift:779 |
:warning: | Source/Device.generated.swift#L780 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:780 |
:warning: | Source/Device.generated.swift#L785 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:785 |
:warning: | Source/Device.generated.swift#L791 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:791 |
:warning: | Source/Device.generated.swift#L796 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:796 |
:warning: | Source/Device.generated.swift#L801 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:801 |
:warning: | Source/Device.generated.swift#L806 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:806 |
:warning: | Source/Device.generated.swift#L811 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:811 |
:warning: | Source/Device.generated.swift#L816 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:816 |
:warning: | Source/Device.generated.swift#L821 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:821 |
:warning: | Source/Device.generated.swift#L826 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:826 |
:warning: | Source/Device.generated.swift#L831 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:831 |
:warning: | Source/Device.generated.swift#L836 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:836 |
:warning: | Source/Device.generated.swift#L841 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:841 |
:warning: | Source/Device.generated.swift#L846 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:846 |
:warning: | Source/Device.generated.swift#L851 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:851 |
:warning: | Source/Device.generated.swift#L856 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:856 |
:warning: | Source/Device.generated.swift#L861 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:861 |
:warning: | Source/Device.generated.swift#L866 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:866 |
:warning: | Source/Device.generated.swift#L871 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:871 |
:warning: | Source/Device.generated.swift#L876 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:876 |
:warning: | Source/Device.generated.swift#L881 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:881 |
:warning: | Source/Device.generated.swift#L886 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:886 |
:warning: | Source/Device.generated.swift#L891 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:891 |
:warning: | Source/Device.generated.swift#L896 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:896 |
:warning: | Source/Device.generated.swift#L901 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:901 |
:warning: | Source/Device.generated.swift#L918 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:918 |
:warning: | Source/Device.generated.swift#L951 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:951 |
:warning: | Source/Device.generated.swift#L958 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:958 |
:warning: | Source/Device.generated.swift#L1335 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:1335 |
:warning: | Source/Device.generated.swift#L1397 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:1397 |
:warning: | Source/Device.generated.swift#L1447 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:1447 |
:warning: | Source/Device.generated.swift#L1504 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:1504 |
:warning: | Source/Device.generated.swift#L1509 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:1509 |
:warning: | Source/Device.generated.swift#L1515 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:1515 |
:warning: | Source/Device.generated.swift#L1526 - Prefer empty collection over optional collection.discouraged_optional_collection Device.generated.swift:1526 |
:warning: | Source/Device.generated.swift#L1572 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:1572 |
:warning: | Source/Device.generated.swift#L1678 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:1678 |
:warning: | Source/Device.generated.swift#L1684 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:1684 |
:warning: | Source/Device.generated.swift#L1689 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:1689 |
:warning: | Source/Device.generated.swift#L1694 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:1694 |
:warning: | Source/Device.generated.swift#L1699 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:1699 |
:warning: | Source/Device.generated.swift#L1704 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:1704 |
:warning: | Source/Device.generated.swift#L1710 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:1710 |
:warning: | Source/Device.generated.swift#L1715 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:1715 |
:warning: | Source/Device.generated.swift#L1720 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:1720 |
:warning: | Source/Device.generated.swift#L1725 - Prefer implicit returns in closures, functions and getters.implicit_return Device.generated.swift:1725 |
:warning: | Tests/Tests.swift#L45 - TODOs should be resolved (failed for iPod touch (7th gen…).todo Tests.swift:45 |
File | Line | Reason |
---|---|---|
Tests.swift | 45 | TODOs should be resolved (failed for iPod touch (7th gen...). (todo) |
Device.generated.swift | 779 | Prefer non-optional booleans over optional booleans. (discouraged_optional_boolean) |
Device.generated.swift | 1526 | Prefer empty collection over optional collection. (discouraged_optional_collection) |
Device.generated.swift | 367 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 678 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 683 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 688 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 694 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 699 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 704 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 709 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 714 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 719 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 724 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 729 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 735 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 740 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 745 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 750 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 755 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 762 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 770 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 776 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 780 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 785 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 791 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 796 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 801 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 806 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 811 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 816 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 821 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 826 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 831 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 836 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 841 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 846 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 851 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 856 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 861 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 866 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 871 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 876 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 881 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 886 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 891 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 896 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 901 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 918 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 951 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 958 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 1335 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 1397 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 1447 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 1504 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 1509 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 1515 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 1572 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 1678 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 1684 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 1689 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 1694 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 1699 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 1704 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 1710 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 1715 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 1720 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 1725 | Prefer implicit returns in closures, functions and getters. (implicit_return) |
Device.generated.swift | 263 | TODOs should be resolved ()). (todo) |
Device.generated.swift | 265 | TODOs should be resolved ()). (todo) |
Device.generated.swift | 267 | TODOs should be resolved ()). (todo) |
Device.generated.swift | 269 | TODOs should be resolved ()). (todo) |
Device.generated.swift | 284 | TODOs should be resolved ()). (todo) |
Device.generated.swift | 286 | TODOs should be resolved ()). (todo) |
Generated by :no_entry_sign: Danger
well nothing to do with this branch or CI things, I close this now and investigate on the original PR. The tests fail on non iOS platforms.
Fix the Device.systemName property #283 Something is wrong with the CI pipeline in the other PR... I cherrypicked the changes here... Let's see...