search

devicekit / DeviceKit

DeviceKit is a value-type replacement of UIDevice.
MIT License
4.42k stars 428 forks source link

Fix invalid iPad Mini (6th generation) aspect ratio (again) #300

Closed Zandor300 closed 2 years ago

Zandor300 commented 2 years ago

iPad Mini (6th generation) aspect ratio was reversed. Thanks @oTranAnhMinh for reporting in https://github.com/devicekit/DeviceKit/issues/299

Also added missing support urls and support images for a bunch of devices.

Fixes https://github.com/devicekit/DeviceKit/issues/299

github-actions[bot] commented 2 years ago
68 Warnings
:warning: Plist changed, don't forget to localize your plist values
:warning: Source/Device.generated.swift#L391 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:391
:warning: Source/Device.generated.swift#L720 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:720
:warning: Source/Device.generated.swift#L725 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:725
:warning: Source/Device.generated.swift#L730 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:730
:warning: Source/Device.generated.swift#L736 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:736
:warning: Source/Device.generated.swift#L741 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:741
:warning: Source/Device.generated.swift#L746 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:746
:warning: Source/Device.generated.swift#L751 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:751
:warning: Source/Device.generated.swift#L756 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:756
:warning: Source/Device.generated.swift#L761 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:761
:warning: Source/Device.generated.swift#L766 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:766
:warning: Source/Device.generated.swift#L771 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:771
:warning: Source/Device.generated.swift#L777 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:777
:warning: Source/Device.generated.swift#L782 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:782
:warning: Source/Device.generated.swift#L787 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:787
:warning: Source/Device.generated.swift#L792 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:792
:warning: Source/Device.generated.swift#L797 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:797
:warning: Source/Device.generated.swift#L804 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:804
:warning: Source/Device.generated.swift#L812 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:812
:warning: Source/Device.generated.swift#L818 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:818
:warning: Source/Device.generated.swift#L821 - Prefer non-optional booleans over optional booleans.
discouraged_optional_boolean Device.generated.swift:821
:warning: Source/Device.generated.swift#L822 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:822
:warning: Source/Device.generated.swift#L827 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:827
:warning: Source/Device.generated.swift#L833 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:833
:warning: Source/Device.generated.swift#L838 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:838
:warning: Source/Device.generated.swift#L843 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:843
:warning: Source/Device.generated.swift#L848 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:848
:warning: Source/Device.generated.swift#L853 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:853
:warning: Source/Device.generated.swift#L858 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:858
:warning: Source/Device.generated.swift#L863 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:863
:warning: Source/Device.generated.swift#L868 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:868
:warning: Source/Device.generated.swift#L873 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:873
:warning: Source/Device.generated.swift#L878 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:878
:warning: Source/Device.generated.swift#L883 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:883
:warning: Source/Device.generated.swift#L888 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:888
:warning: Source/Device.generated.swift#L893 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:893
:warning: Source/Device.generated.swift#L898 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:898
:warning: Source/Device.generated.swift#L903 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:903
:warning: Source/Device.generated.swift#L908 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:908
:warning: Source/Device.generated.swift#L913 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:913
:warning: Source/Device.generated.swift#L918 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:918
:warning: Source/Device.generated.swift#L923 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:923
:warning: Source/Device.generated.swift#L928 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:928
:warning: Source/Device.generated.swift#L933 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:933
:warning: Source/Device.generated.swift#L938 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:938
:warning: Source/Device.generated.swift#L943 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:943
:warning: Source/Device.generated.swift#L960 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:960
:warning: Source/Device.generated.swift#L993 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:993
:warning: Source/Device.generated.swift#L1000 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:1000
:warning: Source/Device.generated.swift#L1391 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:1391
:warning: Source/Device.generated.swift#L1453 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:1453
:warning: Source/Device.generated.swift#L1503 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:1503
:warning: Source/Device.generated.swift#L1560 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:1560
:warning: Source/Device.generated.swift#L1565 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:1565
:warning: Source/Device.generated.swift#L1571 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:1571
:warning: Source/Device.generated.swift#L1582 - Prefer empty collection over optional collection.
discouraged_optional_collection Device.generated.swift:1582
:warning: Source/Device.generated.swift#L1628 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:1628
:warning: Source/Device.generated.swift#L1742 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:1742
:warning: Source/Device.generated.swift#L1748 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:1748
:warning: Source/Device.generated.swift#L1753 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:1753
:warning: Source/Device.generated.swift#L1758 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:1758
:warning: Source/Device.generated.swift#L1763 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:1763
:warning: Source/Device.generated.swift#L1768 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:1768
:warning: Source/Device.generated.swift#L1774 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:1774
:warning: Source/Device.generated.swift#L1779 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:1779
:warning: Source/Device.generated.swift#L1784 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:1784
:warning: Source/Device.generated.swift#L1789 - Prefer implicit returns in closures, functions and getters.
implicit_return Device.generated.swift:1789

SwiftLint found issues

Warnings

File Line Reason
Device.generated.swift 821 Prefer non-optional booleans over optional booleans. (discouraged_optional_boolean)
Device.generated.swift 1582 Prefer empty collection over optional collection. (discouraged_optional_collection)
Device.generated.swift 391 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 720 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 725 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 730 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 736 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 741 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 746 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 751 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 756 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 761 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 766 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 771 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 777 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 782 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 787 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 792 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 797 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 804 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 812 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 818 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 822 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 827 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 833 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 838 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 843 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 848 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 853 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 858 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 863 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 868 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 873 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 878 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 883 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 888 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 893 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 898 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 903 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 908 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 913 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 918 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 923 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 928 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 933 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 938 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 943 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 960 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 993 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 1000 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 1391 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 1453 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 1503 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 1560 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 1565 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 1571 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 1628 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 1742 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 1748 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 1753 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 1758 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 1763 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 1768 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 1774 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 1779 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 1784 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 1789 Prefer implicit returns in closures, functions and getters. (implicit_return)
Device.generated.swift 676 Underscores should be used as thousand separator in large decimal numbers. (number_separator)

Generated by :no_entry_sign: Danger

denisenepraunig commented 2 years ago

Thanks @Zandor300 !