search

devicekit / DeviceKit

DeviceKit is a value-type replacement of UIDevice.
MIT License
4.42k stars 428 forks source link

Device.description returns wrong values #301

Open mklschreiber opened 2 years ago

mklschreiber commented 2 years ago

The current version returns different values for know devices. If I'm using an iPhone XR in combination with the API Device.description I'm getting the result "iPhone XR". If I'm using an iPhone 12 Pro the Device.description returns the value "iPhone13,3".

We checked the enum but didn't see the error. Could you please check it?

Zandor300 commented 2 years ago

That means that the library version that you are using doesn't have iPhone 12 Pro support. Which version of DeviceKit are you using? iPhone 12 series support was added in version 4.2.0, the latest version is 4.5.2.

pod 'DeviceKit', '~> 4.5'
mklschreiber commented 2 years ago

we are using the version 4.5.1 which should support those models... I added a workaround in my project by checking your string for the pattern (iPhone|iPad)XX,X and then switching to the known cases provided by your enum. Therefore the devices are known for the lib but the value returned to our application is wrong...