devicekit / DeviceKit

DeviceKit is a value-type replacement of UIDevice.
MIT License
4.44k stars 433 forks source link

Add support for new September 2022 devices #324

Closed Zandor300 closed 2 years ago

Zandor300 commented 2 years ago

iPhone

Apple Watch

Fixes https://github.com/devicekit/DeviceKit/issues/323 Fixes https://github.com/devicekit/DeviceKit/issues/326 Fixes https://github.com/devicekit/DeviceKit/issues/306

github-actions[bot] commented 2 years ago
3 Warnings
:warning: Plist changed, don't forget to localize your plist values
:warning: Source/Device.generated.swift#L251 - TODOs should be resolved ()).
todo Device.generated.swift:251
:warning: Source/Device.generated.swift#L253 - TODOs should be resolved ()).
todo Device.generated.swift:253

SwiftLint found issues

Warnings

File Line Reason
Device.generated.swift 187 TODOs should be resolved ()). (todo)
Device.generated.swift 189 TODOs should be resolved ()). (todo)
Device.generated.swift 191 TODOs should be resolved ()). (todo)
Device.generated.swift 193 TODOs should be resolved ()). (todo)
Device.generated.swift 195 TODOs should be resolved ()). (todo)
Device.generated.swift 197 TODOs should be resolved ()). (todo)
Device.generated.swift 199 TODOs should be resolved ()). (todo)
Device.generated.swift 201 TODOs should be resolved ()). (todo)
Device.generated.swift 251 TODOs should be resolved ()). (todo)
Device.generated.swift 253 TODOs should be resolved ()). (todo)
Device.generated.swift 409 TODOs should be resolved ()). (todo)
Device.generated.swift 411 TODOs should be resolved ()). (todo)
Device.generated.swift 413 TODOs should be resolved ()). (todo)
Device.generated.swift 415 TODOs should be resolved ()). (todo)
Device.generated.swift 417 TODOs should be resolved ()). (todo)
Device.generated.swift 419 TODOs should be resolved ()). (todo)
Device.generated.swift 421 TODOs should be resolved ()). (todo)
Device.generated.swift 423 TODOs should be resolved ()). (todo)
Device.generated.swift 425 TODOs should be resolved ()). (todo)
Device.generated.swift 427 TODOs should be resolved ()). (todo)

Generated by :no_entry_sign: Danger

jimmycooks9 commented 2 years ago

hi @denisenepraunig - I'm sure you're busy but if could you find some time to review @Zandor300's commit when you get a chance it would be amazing with iOS 16, macOS 12.4, watchOS 9 and such releasing today, in addition to Xcode 14 officially releasing.

Thank you.

p.s. I've reviewed.. LGTM.

denisenepraunig commented 2 years ago

@jimmycooks9 - sorry for being late...