devicekit / DeviceKit

DeviceKit is a value-type replacement of UIDevice.
MIT License
4.4k stars 425 forks source link

Adds compilation support for visionOS. #356

Closed Zandor300 closed 10 months ago

Zandor300 commented 1 year ago

Add support for compiling DeviceKit for visionOS. It does however produce the following warning 3 times when compiling DeviceKit with Xcode 14 or lower:

#if os(xrOS)
       ^
Unknown operating system for build configuration 'os'

Please note that full visionOS support is not the goal of this PR. It is just to fix the compilation errors that occur when compiling for visionOS.

Fixes https://github.com/devicekit/DeviceKit/issues/355

github-actions[bot] commented 1 year ago
17 Warnings
:warning: Plist changed, don't forget to localize your plist values
:warning: Source/Device.generated.swift#L189 - TODOs should be resolved ()).
todo Device.generated.swift:189
:warning: Source/Device.generated.swift#L193 - TODOs should be resolved ()).
todo Device.generated.swift:193
:warning: Source/Device.generated.swift#L197 - TODOs should be resolved ()).
todo Device.generated.swift:197
:warning: Source/Device.generated.swift#L201 - TODOs should be resolved ()).
todo Device.generated.swift:201
:warning: Source/Device.generated.swift#L249 - TODOs should be resolved (.png)).
todo Device.generated.swift:249
:warning: Source/Device.generated.swift#L255 - TODOs should be resolved ()).
todo Device.generated.swift:255
:warning: Source/Device.generated.swift#L257 - TODOs should be resolved ()).
todo Device.generated.swift:257
:warning: Source/Device.generated.swift#L325 - TODOs should be resolved (.png)).
todo Device.generated.swift:325
:warning: Source/Device.generated.swift#L329 - TODOs should be resolved (.png)).
todo Device.generated.swift:329
:warning: Source/Device.generated.swift#L348 - TODOs should be resolved ()).
todo Device.generated.swift:348
:warning: Source/Device.generated.swift#L350 - TODOs should be resolved (.png)).
todo Device.generated.swift:350
:warning: Source/Device.generated.swift#L427 - TODOs should be resolved ()).
todo Device.generated.swift:427
:warning: Source/Device.generated.swift#L431 - TODOs should be resolved ()).
todo Device.generated.swift:431
:warning: Source/Device.generated.swift#L435 - TODOs should be resolved ()).
todo Device.generated.swift:435
:warning: Source/Device.generated.swift#L439 - TODOs should be resolved ()).
todo Device.generated.swift:439
:warning: Source/Device.generated.swift#L443 - TODOs should be resolved ()).
todo Device.generated.swift:443

SwiftLint found issues

Warnings

File Line Reason
Device.generated.swift 189 TODOs should be resolved ()). (todo)
Device.generated.swift 193 TODOs should be resolved ()). (todo)
Device.generated.swift 197 TODOs should be resolved ()). (todo)
Device.generated.swift 201 TODOs should be resolved ()). (todo)
Device.generated.swift 249 TODOs should be resolved (.png)). (todo)
Device.generated.swift 255 TODOs should be resolved ()). (todo)
Device.generated.swift 257 TODOs should be resolved ()). (todo)
Device.generated.swift 325 TODOs should be resolved (.png)). (todo)
Device.generated.swift 329 TODOs should be resolved (.png)). (todo)
Device.generated.swift 348 TODOs should be resolved ()). (todo)
Device.generated.swift 350 TODOs should be resolved (.png)). (todo)
Device.generated.swift 427 TODOs should be resolved ()). (todo)
Device.generated.swift 431 TODOs should be resolved ()). (todo)
Device.generated.swift 435 TODOs should be resolved ()). (todo)
Device.generated.swift 439 TODOs should be resolved ()). (todo)
Device.generated.swift 443 TODOs should be resolved ()). (todo)

Generated by :no_entry_sign: Danger

Zandor300 commented 10 months ago

Cherrypicked this PR into https://github.com/devicekit/DeviceKit/pull/362

Zandor300 commented 10 months ago

Merged to master through https://github.com/devicekit/DeviceKit/pull/362