search

devicekit / DeviceKit

DeviceKit is a value-type replacement of UIDevice.
MIT License
4.4k stars 425 forks source link

Add newly released devices #359

Closed LaurentiuUngur closed 10 months ago

andrewhargreaves commented 10 months ago

Agreed. Would be most appreciated.

kushal211 commented 10 months ago

Here's the identifier for the new iPhone devices:

iPhone 15 iPhone15,4

iPhone 15 Plus iPhone15,5

iPhone 15 Pro iPhone16,1

iPhone 15 Pro Max iPhone16,2

furiosFast commented 10 months ago

there is a new PR: https://github.com/devicekit/DeviceKit/pull/360

fandongtongxue commented 10 months ago

+1

HoustonDuane commented 10 months ago

Apple actually doesn't call the new camera on iPhone 15 Pro Max "Periscope". It's still called "Telephoto camera".

image
Zandor300 commented 10 months ago

Apple is using "telephoto camera" to describe the 5x lens on iPhone 15 Pro Max, so I think it is best to stick to that. I might be better to add extra functionality to DeviceKit to check how much zoom the device's telephoto camera is:

But that is for another time, first need to add support for the devices.

Zandor300 commented 10 months ago

Fixed by https://github.com/devicekit/DeviceKit/pull/360 through https://github.com/devicekit/DeviceKit/pull/362