devicekit / DeviceKit

DeviceKit is a value-type replacement of UIDevice.
MIT License
4.4k stars 425 forks source link

Add new iPhone 15 Series to DeviceKit #360

Closed wo-ist-henry closed 10 months ago

wo-ist-henry commented 10 months ago

Add support for ne the iPhone Series, also added the new camera type Periscope to differentiate between the zoom capabilities that the iPhone 15 Pro Max and all the others has.

LaurentiuUngur commented 10 months ago

Maybe new watches should be added as well

wo-ist-henry commented 10 months ago

I thought I'd add them separately so there's not a huge PR coming in.

wo-ist-henry commented 10 months ago

@LaurentiuUngur I added them with a new PR, #361

Zandor300 commented 10 months ago

@wo-ist-henry Apple is using "telephoto camera" to describe the 5x lens on iPhone 15 Pro Max, so I think it is best to stick to that. I might be better to add extra functionality to DeviceKit to check how much zoom the device's telephoto camera is:

But that is for another time, first need to add support for the devices. I cherrypicked your PR into a release PR, I will change it back to telephoto for now over there. https://github.com/devicekit/DeviceKit/pull/362

Zandor300 commented 10 months ago

Cherrypicked this PR into https://github.com/devicekit/DeviceKit/pull/362

Zandor300 commented 10 months ago

Merged to master through https://github.com/devicekit/DeviceKit/pull/362