search

devicekit / DeviceKit

DeviceKit is a value-type replacement of UIDevice.
MIT License
4.39k stars 425 forks source link

Please use cocoapod resource_bundles for PrivacyInfo #396

Closed RayJiang16 closed 2 months ago

RayJiang16 commented 4 months ago

like sentry https://github.com/getsentry/sentry-cocoa/pull/3651 otherwise we cannot build project

baiyidjp commented 3 months ago

How did you adapt this library? @RayJiang16

RayJiang16 commented 3 months ago

I added PrivacyInfo.xcprivacy to the main project. This is a demo that cannot be build. TestPrivacyInfo.zip

li-jun commented 3 months ago

please use 

s.resource_bundles = {"DeviceKit" => ["Source/PrivacyInfo.xcprivacy"]}

instead of

s.resources                  = 'Source/PrivacyInfo.xcprivacy'

Otherwise, the PrivacyInfo file in the main project will be overwritten.

anton-plebanovich commented 3 months ago

Resolved in https://github.com/devicekit/DeviceKit/pull/397 I guess we may use fork repo as a workaround for now

  # TODO: Restore when the issue is resolved
  # https://github.com/devicekit/DeviceKit/issues/396
  # https://github.com/devicekit/DeviceKit/pull/397
  pod 'DeviceKit', :git => 'https://github.com/RayJiang16/DeviceKit', :commit => 'd0033296a30edfb294b78a64a26e708e8fff6339'
Zandor300 commented 2 months ago

Thanks @RayJiang16 for your fix. Merged and released just now in v5.2.3!