search

devicekit / DeviceKit

DeviceKit is a value-type replacement of UIDevice.
MIT License
4.44k stars 433 forks source link

Add unknown orientation variant #411

Closed GeorgeElsham closed 4 months ago

GeorgeElsham commented 5 months ago

Fixes #410

GeorgeElsham commented 4 months ago

@Zandor300 I don't believe any of the CI should fail, and it appeared to fail when trying to download Ruby. Is it worth you re-running the CI?

Zandor300 commented 4 months ago

@GeorgeElsham Is it possible for you to update your PR from master? I've fixed the CI test jobs. Someone removed the ruby version we were using and that is fixed on master.

Danger job is broken when running on a PR that merges from a fork so don't mind that.

GeorgeElsham commented 4 months ago

I've not really dealt with using forks and pull requests on GitHub. I used GitHub's "Sync fork" button but it seems to have merged your master into my PR branch. If this is okay, we can continue. Otherwise, let me know if I should rebase instead.

GeorgeElsham commented 4 months ago

@Zandor300 Are we okay to merge this in the next release?