devicetree-org / dt-schema

Devicetree schema tools
http://www.devicetree.org
BSD 2-Clause "Simplified" License
67 stars 67 forks source link

Raising the jsonschema cap to allow 4.18.* #108

Closed tjni closed 1 year ago

tjni commented 1 year ago

Hello!

I see that https://github.com/devicetree-org/dt-schema/commit/188cca9ae852edf1f21906c6a2912d52dd90144b mentions there were some issues with jsonschema 4.18. Would it be possible to test if those still remain? I can also offer some time on this too if you remember some details on what went wrong last time.

robherring commented 1 year ago

Yes, the problem remains. Here's the issue I filed with jsonschema: https://github.com/python-jsonschema/jsonschema/issues/1085

I don't see a fix for it other than moving to the referencing interface added in 4.18. I have that working. But then 4.18 becomes our minimum requirement. That in turn makes Rust a requirement which has generated lots of complaints (as has 4.18 breaking other users). So for now I just plan to let things settle out.

tjni commented 1 year ago

Thank you for the detail and clarification, that makes sense. I'll check back perhaps in a few months (or let me know roughly when) to see if the situation is any better (fingers crossed). Thanks again!