search

devicetree-org / dt-schema

Devicetree schema tools
http://www.devicetree.org
BSD 2-Clause "Simplified" License
67 stars 67 forks source link

No warnings for unmatched compatibles ("-m") #122

Closed krzk closed 10 months ago

krzk commented 10 months ago

-m argument stopped working on 2023.09 and 2023.11 (did not look earlier).

  1. Apply https://lore.kernel.org/r/20231212094900.12615-2-quic_tengfan@quicinc.com
  2. Check the binding with -m: 
    make DT_CHECKER_FLAGS=-m dt_binding_check DT_SCHEMA_FILES=qcom,sm4450-tlmm.yaml

Result: everything fine Expected result: warning for unmatched compatible (qcom,sm4450-pinctrl is documented, not qcom,sm4450-tlmm)

robherring commented 10 months ago

The issue is the check is picking up compatible patterns from the qcom naming patterns schema. IOW, almost no qcom compatible is checked. I'm modifying the schema generation to skip any patterns which don't have both start and end anchors or have '.*' or '.+' in the pattern. That eliminates those patterns and a bunch from at24.yaml.