search

devicetree-org / dt-schema

Devicetree schema tools
http://www.devicetree.org
BSD 2-Clause "Simplified" License
67 stars 67 forks source link

schemas: chosen: Allow 32-bit memory ranges for memory range properties #128

Closed refractionware closed 8 months ago

refractionware commented 8 months ago

These properties were moved from 64-bit-specific schemas, but were never updated to allow non-64-bit memory ranges. Since there is nothing 64-bit-specific about them, update their definitions to allow 32-bit memory ranges.

robherring commented 8 months ago

The intent on all of these properties is they are fixed 64-bit and not dependent on #address-cells/#size-cells. It simplifies parsing/writing the properties which is done at runtime.

refractionware commented 8 months ago

The intent on all of these properties is they are fixed 64-bit and not dependent on #address-cells/#size-cells.

Does this mean that this part of their description is incorrect?

      While this property does not represent a real hardware, the address
      and the size are expressed in #address-cells and #size-cells,
      respectively, of the root node.

I'd assume from that description that these properties should inherit the same cell size as reg properties (in which case, my PR is likely still wrong - these would need to adapt to address-cells/size-cells sizing... I suppose I can see the complexity now :) )

robherring commented 8 months ago

I was confused... Your change is correct.