devicons / devicon

Set of icons representing programming languages, designing & development tools
https://devicon.dev
MIT License
9.19k stars 2.26k forks source link

update icon: confluence (original, original-wordmark) #1045

Closed jusuchin85 closed 2 years ago

jusuchin85 commented 2 years ago

New icon section

Double check these details before you open a PR

Link to prove your SVG is correct and up-to-date

https://atlassian.design/resources/logo-library/

As requested in #998

github-actions[bot] commented 2 years ago

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files: Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs. This is how Icomoon intepret the uploaded SVGs: Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon: Imgur Images

Here are the zoomed-in screenshots of the added icons as icons. This is what the font will look like: Imgur Images Imgur Images

You can click on the pictures and zoom on them if needed.

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers, Peek Bot :blush:

Thomas-Boi commented 2 years ago

@jusuchin85 can you ensure the text for this and bitbucket follows Icomoon's standards? If they already are, look at problem number 4 in our common bugs issues.

jusuchin85 commented 2 years ago

@jusuchin85 can you ensure the text for this and bitbucket follows Icomoon's standards? If they already are, look at problem number 4 in our common bugs issues.

Will do!

Thomas-Boi commented 2 years ago

@jusuchin85 are you still working on this PR?

jusuchin85 commented 2 years ago

Ah sorry @Thomas-Boi - Still am, real-life work caught up with me.

I'll update this and the Bitbucket PR soon.

jusuchin85 commented 2 years ago

@Thomas-Boi @Panquesito7 - updated PR with new commits. Hopefully, this will fix the icon text appropriately. 😃

github-actions[bot] commented 2 years ago

env.MESSAGE

github-actions[bot] commented 2 years ago

env.MESSAGE

Thomas-Boi commented 2 years ago

I know what's wrong. There was an update to peek_bot in check_svg PR. It changed some command line args. I'll push a fix

github-actions[bot] commented 2 years ago

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files: Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs. This is how Icomoon intepret the uploaded SVGs: Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon: Imgur Images

Here are the zoomed-in screenshots of the added icons as icons. This is what the font will look like: Imgur Images Imgur Images

You can click on the pictures and zoom on them if needed.

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers, Peek Bot :blush:

Thomas-Boi commented 2 years ago

@jusuchin85 everything looks good to me. Thank you very much for the PR. I'll leave this PR open temporary to test a script upgrade. Once that's tested and no other errors show up, I'll merge the PR 👍.

@Panquesito7 please review and merge this PR first 😄. Forgot to do something so this PR will fix it.

jusuchin85 commented 2 years ago

Thanks @Thomas-Boi ! Happy to help!

I'll look and see whether there are any other Atlassian icons to update in the meantime. 😄

Thomas-Boi commented 2 years ago

Thanks @Thomas-Boi ! Happy to help!

I'll look and see whether there are any other Atlassian icons to update in the meantime. 😄

That sounds good. Just fyi that we are looking to make a new release soon (hopefully next week). If you can get it in by then would be great.

jusuchin85 commented 2 years ago

Icons resized accordingly using iloveimg. Thanks for pointing this out, @Thomas-Boi !

github-actions[bot] commented 2 years ago

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files: Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs. This is how Icomoon intepret the uploaded SVGs: Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon: Imgur Images

Here are the zoomed-in screenshots of the added icons as icons. This is what the font will look like: Imgur Images Imgur Images

You can click on the pictures and zoom on them if needed.

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers, Peek Bot :blush:

jusuchin85 commented 2 years ago

Happy to help!