devicons / devicon

Set of icons representing programming languages, designing & development tools
https://devicon.dev
MIT License
9.19k stars 2.26k forks source link

new icon: jiraalign (original,plain,original-wordmark,plain-wordmark) #1468

Closed yeyeto2788 closed 1 year ago

yeyeto2788 commented 1 year ago

Double check these details before you open a PR

This PR closes #789

Link to prove your SVG is correct and up-to-date.

yeyeto2788 commented 1 year ago

That is really weird cuz I do see it correctly in Inkscape image

Any suggestions on how to fix it? Maybe exporting it differently?

yeyeto2788 commented 1 year ago

I'll grouping them to see if that fixes the issue.

yeyeto2788 commented 1 year ago

I had to use the ones you provided on the issue itself as the grouping didn't work. Thanks for that!

lunatic-fox commented 1 year ago

Hello there! @yeyeto2788 you're doing great! I just have some recommendations to the icons. First, I think you'll need to change the icons name and add two more icons:

And add the original and plain icons based on the square-like icon recommended by @Snailedlt on #789 issue.

To original-wordmark icon you can ungroup all and unify just "Jira Align" characters in one path. To plain-wordmark icon, you can ungroup all and unify all in just one path. All icons need to be an 128×128px square.

Wish for the best!

yeyeto2788 commented 1 year ago

Hey @lunatic-fox!

I think I have covered everything you asked me for but if you see there is something missing just let me know.

Best.

lunatic-fox commented 1 year ago

The icons look great now @yeyeto2788! 🤩

However there are some issues yet:

Keep rocking! 🚀

yeyeto2788 commented 1 year ago

Hey @lunatic-fox!

I hope this time is correct. So for uniting the path I followed these steps:

  1. Ungroup the objects Ctrl Shift G
  2. Select all Ctrl A
  3. Path > Union Ctrl + +

I guess that could be added into the documentation. I really helped me a lot the example with the box creation and this might as well help others.

lunatic-fox commented 1 year ago

Hello @yeyeto2788! In short:

But plain-wordmark is grouped. The key command to ungroup is Shift+Ctrl+G, otherwise it'll probably group instead. However, you can also follow that way bellow.

Checking layers

Hope everything works fine! 👍🏼

yeyeto2788 commented 1 year ago

Hopefully this one is the last one. Once again sorry for the inconveniences.

Best.

lunatic-fox commented 1 year ago

No worries! There is no inconvenience at all. 🙂 Like the other PR, I haven't seen before just two things: the altnames and tags properties are missing after name property.

Suggestions of tags

"tags": [
    "development",
    "integration",
    "software"
]

The icons are great now! 🎉

Like I said before you can also contact us on Discord server.

I also loved your idea of adding some instructions on using Inkscape! I think this should be a feature request to the Wiki.

Snailedlt commented 1 year ago

@yeyeto2788

Hey @lunatic-fox!

I hope this time is correct. So for uniting the path I followed these steps:

  1. Ungroup the objects Ctrl Shift G
  2. Select all Ctrl A
  3. Path > Union Ctrl + +

I guess that could be added into the documentation. I really helped me a lot the example with the box creation and this might as well help others.

Yes, this could be added to the wiki as a part of this issue: #1306

lunatic-fox commented 1 year ago

@yeyeto2788

Hey @lunatic-fox! I hope this time is correct. So for uniting the path I followed these steps:

  1. Ungroup the objects Ctrl Shift G
  2. Select all Ctrl A
  3. Path > Union Ctrl + +

I guess that could be added into the documentation. I really helped me a lot the example with the box creation and this might as well help others.

Yes, this could be added to the wiki as a part of this issue: #1306

I'll be adding this later Instructions to resize to square and Checking layers.

Snailedlt commented 1 year ago

@lunatic-fox Nice! Please add links to those as comments with the same format I used in the issue I created: #1306

github-actions[bot] commented 1 year ago

Hi!

I'm the check-bot and we have some issues with your PR:

SVG Error in 'jiraalign-plain.svg':
- 'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg.

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help, SVG-Checker Bot :smile:

Snailedlt commented 1 year ago

Hi!

I'm the check-bot and we have some issues with your PR:

SVG Error in 'jiraalign-plain.svg':
- 'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg.

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help, SVG-Checker Bot 😄

@yeyeto2788 Please resize the viewbox as explained above. I recommend using iloveimg to make it fast and easy :)

github-actions[bot] commented 1 year ago

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files: Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs: Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon: Imgur Images

Here are the zoomed-in screenshots of the added icons as icons: Imgur Images Imgur Images

Here are the colored versions: Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers, Peek Bot :blush:

github-actions[bot] commented 1 year ago

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files: Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs: Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon: Imgur Images

Here are the zoomed-in screenshots of the added icons as icons: Imgur Images Imgur Images

Here are the colored versions: Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers, Peek Bot :blush:

github-actions[bot] commented 1 year ago

env.MESSAGE

yeyeto2788 commented 1 year ago

Looks good now, but the icons are still quite big. Could you please optimize them using this method? #1306 (comment)

I did that step before my last commit but I have done again hoping it does not screw anything as the last time.

Best.

github-actions[bot] commented 1 year ago

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files: Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs: Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon: Imgur Images

Here are the zoomed-in screenshots of the added icons as icons: Imgur Images Imgur Images

Here are the colored versions: Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers, Peek Bot :blush: