[BUG] Optimize icons with SVGO check fails

devicons / devicon

Set of icons representing programming languages, designing & development tools

https://devicon.dev

MIT License

9.66k stars 2.3k forks source link

[BUG] Optimize icons with SVGO check fails #1715

Open Snailedlt opened 1 year ago

Snailedlt commented 1 year ago

I have searched through the issues and didn't find my problem.

[X] Confirm

Bug description

Seems to always fail. I assume it fails because the PR comes from a fork. In which case it's the same issue with permissions as with the in-develop labeler -> #1099

Example of where it fails: https://github.com/devicons/devicon/pull/1705 Here's the failed action run itself: https://github.com/devicons/devicon/actions/runs/4449250809/jobs/7813643642?pr=1705

Possible fixes or solutions

Like I mentioned it's possibly the same issue as with the in-develop labeler, where we solved the issue by running a preflight workflow and uploading the data we need as an artifact, then downloading it in the other workflow.

Additional information

No response

Snailedlt commented 1 year ago

@lunatic-fox I made an issue for the bug. Feel free to edit the description if you have any more info :)

lunatic-fox commented 1 year ago

Thank you! 🚀 Hmm, I don't think I get it yet, should we proceed as Peek Icons workflow, like:

Optimize icons - does modifications on .svg files and saves the PR number into an artifact.
Post optimize icons - is a workflow_run that waits to Optimize icons conclusion and does the commit part to the saved artifact.

I think none of them will need permissions with this solution.

Snailedlt commented 1 year ago

@lunatic-fox sorry for the bad description. It was half intentional since I couldn't remember exactly whta the problem and solution was, so I was hoping you would figure it out 😅 Yes, that sounds like exactly what we need