Closed Yashh56 closed 3 months ago
Hey, Maintainer Please Review This PR !!
how should I convert the original to plain? @weh
I prefer to use Inkscape for this. The goal is to "union all paths". you may need to convert some parts using "Object to Path" or "Stroke to Path" and finally mark all elements and use "path/Union"
Followed by
Iloveimg
Vecta.io
That is my preferred workflow. You can find the Links here: https://github.com/devicons/devicon/wiki/Recommended-resources-and-tools
After merging the path it looks like this
Hey @Yashh56 , sorry for the super long comment, but here's the workflow I follow to create new Icons.
File
option from the toolbar and in the dropdown select Document properties
.width
to 128.height
to 128.ctrl-a
to select all paths.group
from the dropdown.ctrl-a
) and then select ungroup
from the dropdown.Shout out to @yeyeto2788 and @lunatic-fox for these steps.
ctrl-a
to select all paths.ungroup
in the menu to ungroup all paths.Path
option in the toolbar and in the the dropdown select union
to combine all paths into 1 path.Shout out to @BenSouchet, all the steps I used were from this comment
Paste markup
.Features
menu.Compare gzipped
, enable Multipass
, and do not touch the precision slidebar
.
Hey @canaleal Are these changes correct?
After merging the path I am facing the same issue
Hey @Yashh56, I took a look at the Icon and I see what the problem is. The symbol on the left is a stroke, not an object. So when you try to unify all paths together, it gets messed up.
The strokes can be converted into paths by selecting all elements on the page ctrl-a
and then doing ctrl + alt + a
or selecting stroke-to-path in the path dropdown.
You can still follow the workflow I posted above to optimize, resize, and make plain SVGs.
Here, I cleaned up the original SVG and converted it to object paths. This can be used to create the plain icons.
`
`
I will make this changes ASAP @canaleal Thanks for the help
Hey @canaleal Are these changes correct?
Hey, Maintainer Please Review This PR !!
thank you for the help @weh
Wow great tutorial here @canaleal! https://github.com/devicons/devicon/pull/1926#issuecomment-1776317249
Would you mind adding the thing with objects, and adding it to this issue? https://github.com/devicons/devicon/issues/1306
Optimizing the SVG using SVGOMG
I found it more easier to do with it.
Prettify
Button.Optimize
Button.BOOM !!! The SVG is optimized, without ruining the viewbox.
(Hacktobeberfest PR)
PR name matches the format new icon: Icon name (versions separated by a comma). More details here
PR's base is the develop branch.
Your icons are inside a folder as seen here
SVG matches the standards laid out here
A new object is added in the devicon.json file as seen here
This PR closes #1902
Link to prove your SVG is correct and up-to-date. https://codeberg.org/forgejo/governance/media/branch/main/branding/logo/forgejo.svg