devicons / devicon

Set of icons representing programming languages, designing & development tools
https://devicon.dev
MIT License
9.19k stars 2.26k forks source link

new icon: weblate (original, plain, original-wordmark, plain-wordmark) #544

Closed maltejur closed 3 years ago

maltejur commented 3 years ago

Add icon for weblate (localization platform)

Screenshot 2021-04-01 190416

github-actions[bot] commented 3 years ago

Hi!

I'm Devicons' SVG-Checker Bot and it seems we have some issues with your SVGs.

Here is what went wrong:

icons/weblate/weblate-plain.svg:
-unneccessary 'x' attribute in svg element -> Remove it
-unneccessary 'y' attribute in svg element -> Remove it
-contains style declaration using 'fill' -> Replace classes with the 'fill' attribute instead

For more reference on why these are errors, check out our CONTRIBUTING guide

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help, SVG-Checker Bot :smile:

PS. One day, I will be smart enough to fix these errors for you :persevere:. Until then, I can only point them out.

github-actions[bot] commented 3 years ago

Hi! I'm Devicons' SVG-Checker Bot and everything looks great. Good job!

Have a nice day, SVG-Checker Bot :grin:

github-actions[bot] commented 3 years ago

Hi! I'm Devicons' SVG-Checker Bot and everything looks great. Good job!

Have a nice day, SVG-Checker Bot :grin:

github-actions[bot] commented 3 years ago

Hi! I'm Devicons' SVG-Checker Bot and everything looks great. Good job!

Have a nice day, SVG-Checker Bot :grin:

github-actions[bot] commented 3 years ago

Hi! I'm Devicons' SVG-Checker Bot and everything looks great. Good job!

Have a nice day, SVG-Checker Bot :grin:

github-actions[bot] commented 3 years ago

Hi! I'm Devicons' SVG-Checker Bot and everything looks great. Good job!

Have a nice day, SVG-Checker Bot :grin:

github-actions[bot] commented 3 years ago

Hi! I'm Devicons' SVG-Checker Bot and everything looks great. Good job!

Have a nice day, SVG-Checker Bot :grin:

github-actions[bot] commented 3 years ago

Hi! I'm Devicons' SVG-Checker Bot and everything looks great. Good job!

Have a nice day, SVG-Checker Bot :grin:

github-actions[bot] commented 3 years ago

Hi! I'm Devicons' SVG-Checker Bot and everything looks great. Good job!

Have a nice day, SVG-Checker Bot :grin:

github-actions[bot] commented 3 years ago

Hi! I'm Devicons' SVG-Checker Bot and everything looks great. Good job!

Have a nice day, SVG-Checker Bot :grin:

Panquesito7 commented 3 years ago

You should probably consider making the text white for the wordmark versions (see the Weblate website).

maltejur commented 3 years ago

That is just because the website has a dark background, isn't it? I think it is probably more useful if the text is black for the icon.

Panquesito7 commented 3 years ago

~@amacado @Thomas-Boi, there seem to be problems with the Peek Icons workflow. Maybe due to the latest changes in the workflow? 🤔~ Never mind, it seems the workflow wasn't able to connect to the Icomoon website. 🤷‍♂️

github-actions[bot] commented 3 years ago

Hi! I'm Devicons' SVG-Checker Bot and everything looks great. Good job!

Have a nice day, SVG-Checker Bot :grin:

github-actions[bot] commented 3 years ago

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here is the result below:

Imgur Images

Here are the zoomed-in screenshots of the added icons: Imgur ImagesImgur Images

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers, Peek Bot :blush:

amacado commented 3 years ago

~@amacado @Thomas-Boi, there seem to be problems with the Peek Icons workflow. Maybe due to the latest changes in the workflow? 🤔~ Never mind, it seems the workflow wasn't able to connect to the Icomoon website. 🤷‍♂️

Yep. That's a well known bug.

maltejur commented 3 years ago

@amacado would it be possible to create a new release now? I need two new icons that aren't on npm yet.

Thomas-Boi commented 3 years ago

@amacado would it be possible to create a new release now? I need two new icons that aren't on npm yet.

Hey @maltejur, I think we will wait for a couple more days. If there are no more icons then, we'll probably make a new release. I hope that you can wait until then :)