new icon: matlab (line)

[Thomas-Boi]

Taken from #116. Work was done by @Pmz64.

[github-actions[bot]]

Hi!

I'm Devicons' SVG-Checker Bot and it seems we have some issues with your SVGs.

Here is what went wrong:

icons/matlab/matlab-line.svg:
-contains style declaration using 'fill' -> Replace classes with the 'fill' attribute instead

For more reference on why these are errors, check out our CONTRIBUTING guide

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help, SVG-Checker Bot :smile:

PS. One day, I will be smart enough to fix these errors for you :persevere:. Until then, I can only point them out.

[github-actions[bot]]

Hi!

I'm Devicons' SVG-Checker Bot and it seems we've ran into a problem. I'm supposed to check your svgs but I couldn't do my task due to an issue.

Please let my maintainers know of the issues. They will take a look at my work and try to resolve the problem. Until then, please hang tight and sorry for the inconvenience.

Cheers, SVG-Checker Bot :smile:

[github-actions[bot]]

Hi!

I'm Devicons' SVG-Checker Bot and it seems we have some issues with your SVGs.

Here is what went wrong:

icons/matlab/matlab-line.svg:
-contains style declaration using 'fill' -> Replace classes with the 'fill' attribute instead

For more reference on why these are errors, check out our CONTRIBUTING guide

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help, SVG-Checker Bot :smile:

PS. One day, I will be smart enough to fix these errors for you :persevere:. Until then, I can only point them out.

[github-actions[bot]]

Hi!

I'm Devicons' SVG-Checker Bot and it seems we've ran into a problem. I'm supposed to check your svgs but I couldn't do my task due to an issue.

Please let my maintainers know of the issues. They will take a look at my work and try to resolve the problem. Until then, please hang tight and sorry for the inconvenience.

Cheers, SVG-Checker Bot :smile:

[github-actions[bot]]

Hi!

I'm Devicons' SVG-Checker Bot and it seems we have some issues with your SVGs.

Here is what went wrong:

icons/matlab/matlab-line.svg:
-contains style declaration using 'fill' -> Replace classes with the 'fill' attribute instead

For more reference on why these are errors, check out our CONTRIBUTING guide

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help, SVG-Checker Bot :smile:

PS. One day, I will be smart enough to fix these errors for you :persevere:. Until then, I can only point them out.

[github-actions[bot]]

Hi!

I'm Devicons' SVG-Checker Bot and it seems we've ran into a problem. I'm supposed to check your svgs but I couldn't do my task due to an issue.

Please let my maintainers know of the issues. They will take a look at my work and try to resolve the problem. Until then, please hang tight and sorry for the inconvenience.

Cheers, SVG-Checker Bot :smile:

[github-actions[bot]]

Hi!

I'm Devicons' SVG-Checker Bot and it seems we have some issues with your SVGs.

Here is what went wrong:

icons/matlab/matlab-line.svg:
-contains style declaration using 'fill' -> Replace classes with the 'fill' attribute instead

For more reference on why these are errors, check out our CONTRIBUTING guide

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help, SVG-Checker Bot :smile:

PS. One day, I will be smart enough to fix these errors for you :persevere:. Until then, I can only point them out.

[github-actions[bot]]

Hi!

I'm Devicons' SVG-Checker Bot and it seems we've ran into a problem. I'm supposed to check your svgs but I couldn't do my task due to an issue.

Please let my maintainers know of the issues. They will take a look at my work and try to resolve the problem. Until then, please hang tight and sorry for the inconvenience.

Cheers, SVG-Checker Bot :smile:

[github-actions[bot]]

Hi there,

I'm Devicons' Peek Bot and it seems we've ran into a problem (sorry!).

Please double check and fix the possible issues below:

• Your svgs are named and added correctly to the /icons folder as seen here.
• Your icon information has been added to the devicon.json as seen here
• Your PR title follows the format seen here

I will retry once everything is fixed. If I still fail (sorry!) or there are other erros, the maintainers will investigate.

Best of luck, Peek Bot :relaxed:

[github-actions[bot]]

Hi there,

I'm Devicons' Peek Bot and it seems we've ran into a problem (sorry!).

Please double check and fix the possible issues below:

• Your svgs are named and added correctly to the /icons folder as seen here.
• Your icon information has been added to the devicon.json as seen here
• Your PR title follows the format seen here

I will retry once everything is fixed. If I still fail (sorry!) or there are other erros, the maintainers will investigate.

Best of luck, Peek Bot :relaxed:

[amacado]

The problem is within the find_new_icons method https://github.com/devicons/devicon/blob/7a4ca8aa871d6dca81691e018d31eed89cb70a76/.github/scripts/build_assets/filehandler.py#L9

Because matlab (plain version) is already in our icon set (if is_not_in_icomoon_json(icon, icomoon_json)) the line version is not detected as new icon, which results in a failed check.

[Thomas-Boi]

@amacado you are right.

There's also another issue: the build bot won't build this icon either because the folder matlab is already built in icomoon.json. See filehandler.py's find_new_icons() for more details.

I can see two options:

• Build this file manually (quickest)
• Change the build script so whenever it runs, it builds EVERY single SVGs listed as font versions.

I'm leaning towards option 1. However, we might need to address icon updates in the future as well.

[amacado]

@Thomas-Boi would you work on a fix? I think this case could occur more often in the future.. Maybe we should create a issue for this.

[github-actions[bot]]

Hi there,

I'm Devicons' Peek Bot and it seems we've ran into a problem (sorry!).

Please double check and fix the possible issues below:

• Your svgs are named and added correctly to the /icons folder as seen here.
• Your icon information has been added to the devicon.json as seen here
• Your PR title follows the format seen here

I will retry once everything is fixed. If I still fail (sorry!) or there are other erros, the maintainers will investigate.

Best of luck, Peek Bot :relaxed:

[Thomas-Boi]

Here's the issue related to this:

[github-actions[bot]]

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here is the result below (top right):

Here are the zoomed-in screenshots of the added icons:

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers, Peek Bot :blush:

[Thomas-Boi]

I'll merge this in so I can test the new build script. Besides, this is good anyway