Closed MichielPater closed 2 years ago
Hi!
I'm Devicons' SVG-Checker Bot and it seems we have some issues with your SVGs.
Here is what went wrong:
icons/putty/putty-original.svg:
-contains style declaration using 'fill' -> Replace classes with the 'fill' attribute instead
icons/putty/putty-original.svg:
-contains style declaration using 'fill' -> Replace classes with the 'fill' attribute instead
For more reference on why these are errors, check out our CONTRIBUTING guide
Please address these issues. When you update this PR, I will check your SVGs again.
Thanks for your help, SVG-Checker Bot :smile:
PS. One day, I will be smart enough to fix these errors for you :persevere:. Until then, I can only point them out.
Hi!
I'm Devicons' SVG-Checker Bot and it seems we have some issues with your SVGs.
Here is what went wrong:
icons/putty/putty-original.svg:
-contains style declaration using 'fill' -> Replace classes with the 'fill' attribute instead
icons/putty/putty-original.svg:
-contains style declaration using 'fill' -> Replace classes with the 'fill' attribute instead
For more reference on why these are errors, check out our CONTRIBUTING guide
Please address these issues. When you update this PR, I will check your SVGs again.
Thanks for your help, SVG-Checker Bot :smile:
PS. One day, I will be smart enough to fix these errors for you :persevere:. Until then, I can only point them out.
Hey @MichielPater,
Please hold off fixing the fill
issue reported by the bot. I'm trying to find a way to fix this issue permanently using our SVG-optimizer bot.
Hi!
I'm Devicons' SVG-Checker Bot and it seems we have some issues with your SVGs.
Here is what went wrong:
icons/putty/putty-original.svg:
-contains style declaration using 'fill' -> Replace classes with the 'fill' attribute instead
icons/putty/putty-original.svg:
-contains style declaration using 'fill' -> Replace classes with the 'fill' attribute instead
For more reference on why these are errors, check out our CONTRIBUTING guide
Please address these issues. When you update this PR, I will check your SVGs again.
Thanks for your help, SVG-Checker Bot :smile:
PS. One day, I will be smart enough to fix these errors for you :persevere:. Until then, I can only point them out.
Hi!
I'm Devicons' SVG-Checker Bot and it seems we have some issues with your SVGs.
Here is what went wrong:
icons/putty/putty-original.svg:
-contains style declaration using 'fill' -> Replace classes with the 'fill' attribute instead
icons/putty/putty-original.svg:
-contains style declaration using 'fill' -> Replace classes with the 'fill' attribute instead
For more reference on why these are errors, check out our CONTRIBUTING guide
Please address these issues. When you update this PR, I will check your SVGs again.
Thanks for your help, SVG-Checker Bot :smile:
PS. One day, I will be smart enough to fix these errors for you :persevere:. Until then, I can only point them out.
Hi there,
I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here is the result below (top left):
Here are the zoomed-in screenshots of the added icons:
Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.
The maintainers will now take a look at it and decide whether to merge your PR.
Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.
Cheers, Peek Bot :blush:
I agree with @Panquesito7. The original
version is way too complicated to be used as a plain version. Now, how do we make it into a plain version is a bit difficult.
I'd recommend you making a line version containing the outlines of the computers and the lightning bolt. I don't know how to make a plain
version that suits this specific logo unfortunately. If you have any ideas, feel free to push them here and we can run it through the bot.
If you are unwilling to modify the logo, we'll have to close this PR. While the quality is great, if it can't be made into an icon, it can't fit in this repo.
@Thomas-Boi @Panquesito7 added line version and plain version 😀
Almost there! You just have to make the thunderbolt a bit more visible in the line
version. 🙂
Almost there! You just have to make the thunderbolt a bit more visible in the
line
version. 🙂
Thank you! I wonder why it is not visible in the font, while I can see it in my SVG. I'm not sure how to fix it if I cannot reproduce it. What do you think?
Hi there,
I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here is the result below (top left):
Here are the zoomed-in screenshots of the added icons:
Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.
The maintainers will now take a look at it and decide whether to merge your PR.
Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.
Cheers, Peek Bot :blush:
@Panquesito7 it is quite strange. This is also an issue in the other PRs as well. Checking it manually on Icomoon yield no issue. Sometimes, perhaps the SVG just can't be made into an icon.
Btw, @MichielPater, what software do you use to make these SVGs? Just curious.
Luckily, the plain
version looks great 👍. I think we can remove the line
version and just keep the plain
one.
@Panquesito7 it is quite strange. This is also an issue in the other PRs as well. Checking it manually on Icomoon yield no issue. Sometimes, perhaps the SVG just can't be made into an icon.
Btw, @MichielPater, what software do you use to make these SVGs? Just curious.
Luckily, the
plain
version looks great 👍. I think we can remove theline
version and just keep theplain
one.
Hi @Thomas-Boi I am using Inkscape
Hi there,
I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here is the result below (top left):
Here are the zoomed-in screenshots of the added icons:
Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.
The maintainers will now take a look at it and decide whether to merge your PR.
Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.
Cheers, Peek Bot :blush:
Hi!
I'm Devicons' SVG-Checker Bot and it seems we have some issues with your SVGs.
Here is what went wrong:
For more reference on why these are errors, check out our CONTRIBUTING guide
Please address these issues. When you update this PR, I will check your SVGs again.
Thanks for your help, SVG-Checker Bot :smile:
PS. One day, I will be smart enough to fix these errors for you :persevere:. Until then, I can only point them out.