search

devict / devict.org

The amazing devict.org
https://devict.org
6 stars 28 forks source link

Support page reporting NaN #84

Closed Mottie closed 7 years ago

Mottie commented 7 years ago

This PR gets data from the correct attributes & removes a duplicate <script> tag.

Mottie commented 7 years ago

Sorry, I totally didn't read the contributing section... I can resubmit this PR in a branch if you want.

jcbwlkr commented 7 years ago

Awesome! Thanks for fixing that.

The major reason to have your PR come from a feature branch instead of your master branch is that I'm likely to squash or rebase the commits when I bring them in and now your master is incompatible with devICT's master. I've already done that so to fix yours just takes a few steps

Assuming you have your repo set as origin and the devICT repo as upstream you can do this to get your repo back in sync with ours

git fetch upstream
git reset --hard upstream/master
git push --force-with-lease origin master