devict / keeper

devICT Slack Bot
MIT License
2 stars 3 forks source link

Local dev with phony Slack client #2

Closed sethetter closed 2 years ago

KalebMills commented 2 years ago

I was thinking maybe the PhonyClient implements an event emitter or something under the hood. That way, it's super easy to test, and we can test commands through the client as well. Thoughts?

sethetter commented 2 years ago

Yeah an EventEmitter makes a lot of sense!

sethetter commented 2 years ago

Alright I have a basic thing working here but I'm curious whether to focus on the event handler portion or the slash commands. Would it be easiest to just focus on the app_mention event and parsing out the message that is received? Then we don't have to mess with the slack app configuration any time we want to add capabilities to the bot.

Thoughts?

KalebMills commented 2 years ago

Yep I think listening for mentions is the way to go here!

sethetter commented 2 years ago

@KalebMills alright I think this is ready for review. I know it's a lot of change, sorry about that! Things are now set up so that "commands" are specifically things sent to the bot in app_mention events.

KalebMills commented 2 years ago

We also need to update the .env.default CONF_FILE to local so folx can spin it right up with the PhonyClient