devict / votelocal

A web app for receiving local voting information via SMS
15 stars 16 forks source link

Message tagging, and subscription management #88

Closed sethetter closed 4 years ago

sethetter commented 4 years ago

There's a lot going on here, but from a high level..

Since promoting the service by phone number has never really been great, with this new web UI for sign up and subscription management, we can just promote the URL!

How to test this out

Start the system locally, make sure twilio integration is working. Run a fresh migration and DB seeding.

$ docker-compose run --rm php php artisan migrate:fresh
$ make db-seed

To test out subscriber management..

To test the scheduled message tagging..

Generally just poke around a lot and see if anything seems broken, or if anything could be a bit better.

sethetter commented 4 years ago
Screen Shot 2020-07-03 at 10 10 58 PM Screen Shot 2020-07-03 at 10 11 18 PM Screen Shot 2020-07-03 at 10 19 17 PM Screen Shot 2020-07-03 at 10 13 55 PM Screen Shot 2020-07-03 at 10 16 10 PM Screen Shot 2020-07-03 at 10 15 06 PM
sethetter commented 4 years ago

Still working on the couple failing tests, but I have no reason to believe anything is actually broken.

imacrayon commented 4 years ago

Oh I forgot to mention you'll have to yarn install axios after you've rebased with master. That got removed from package.json.

sethetter commented 4 years ago

@imacrayon I think I've got all that resolved, thanks for lining up the suggestions!

I noticed the character count doesn't live update now, seems to be the case in production too though.

imacrayon commented 4 years ago

@sethetter looks like the <textarea> in views/partials/fields/character-count.blade.php is missing an x-model="text" attribute around line 13.

sethetter commented 4 years ago

@imacrayon awesome that did the trick, thanks!