devilry / devilry-django

Devilry project main repository
http://devilry.org
BSD 3-Clause "New" or "Revised" License
51 stars 24 forks source link

Notification template mismatch #1241

Closed torgeirl closed 1 year ago

torgeirl commented 2 years ago

If an examiner that is also semester administrator adds a new comment, the «An examiner added a new comment for » email notification will (wrongly) inform that's its being sent to the semester administrator since no examiners have been assigned the student.

I believe these emails primarily are sent to the examiner making the comments as a form of receipt, and if so, an exception to the templating should be made so they don't contain the «no examiners have been assigned» claim.

It could also be that we don't intend to send out these «receipt emails», but simply haven't accounted for when an examiner that's also is a semester administrator makes a comment to a student's assignment.