devilry / devilry-django

Devilry project main repository
http://devilry.org
BSD 3-Clause "New" or "Revised" License
51 stars 24 forks source link

Feedbackfeed raises Http404 for examiners #1287

Closed torgeirl closed 3 months ago

torgeirl commented 6 months ago

With the release of 6.0.0 we started getting HTTP 404 from transactions for /devilry_group/examiner/{roleid}/feedbackfeed/feedback.

Stack trace:

Http404: null
  File "django/core/handlers/base.py", line 197, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "cradmin_legacy/crapp.py", line 86, in viewwrapper
    return has_access_to_cradmin_instance(cradminview(view))(request, *args, **kwargs)
  File "cradmin_legacy/decorators.py", line 32, in wrapper
    return view_function(request, *args, **kwargs)
  File "cradmin_legacy/decorators.py", line 70, in wrapper
    response = view_function(request, *args, **kwargs)
  File "django/utils/decorators.py", line 134, in _wrapper_view
    response = view_func(request, *args, **kwargs)
  File "django/views/generic/base.py", line 104, in view
    return self.dispatch(request, *args, **kwargs)
  File "devilry/devilry_group/views/examiner/feedbackfeed_examiner.py", line 164, in dispatch
    raise Http404

Not sure exactly what triggers it, but my guess is something from the Django 4.2 and/or Python 3.10 update is still missing.

Levijatan commented 3 months ago

Fixed in 989534c. It was raising 404 when feedback had been published and someone directly went to the view. Changed it to rather redirect to the public-discussion view instead, same as the redirect view.