search

devilry / devilry-django

Devilry project main repository
http://devilry.org
BSD 3-Clause "New" or "Revised" License
51 stars 24 forks source link

DeleteView uses POST (not DELETE) and its handling should therefore be moved to `form_valid()` #1293

Open torgeirl opened 4 months ago

torgeirl commented 4 months ago

Django warning: DeleteViewCustomDeleteWarning: DeleteView uses FormMixin to handle POST requests. As a consequence, any custom deletion logic in GroupCommentDeleteView.delete() handler should be moved to form_valid()

Levijatan commented 3 months ago

Fixed this in 6ee45c5. Moved logic to form_valid() and overwrote delete() with delete() from grandparent since delete() was changed in parent DeleteView from cradmin_legacy.