search

devilry / devilry-django

Devilry project main repository
http://devilry.org
BSD 3-Clause "New" or "Revised" License
51 stars 24 forks source link

Duplicate attempts blocks providing final feedback, stranding assignment as Waiting for feedback #1301

Open torgeirl opened 3 months ago

torgeirl commented 3 months ago

Description If an examiner by mistake grants more than one new attempt and then provides feedback, the student group is stranded at waiting for feedback on the last attempt given after the deadline expires while the examiner is prevented from given further feedback since «Feedback is already published!».

My guess is that the first feedback provided is given to the oldest open attempt, but that the save_object() if-else looks at something else.

Workaround Using Simple bulk feedback an examiner is able to give the student group a grade, and that will also change the status from Waiting for feedback to Corrected.

Levijatan commented 3 months ago

Yup the feedback was given to the oldest attempt. Could not find an east way to make sure that the feedback gets to the newest attempt, so ended up with changing how new attempts are made to check if there is no feedback published it moves the deadline rather then creating a new attempt. Commited in 326a5d4