devilry / devilry-django

Devilry project main repository
http://devilry.org
BSD 3-Clause "New" or "Revised" License
51 stars 24 forks source link

Switch to tar.gz instead of zip for feedbackset downloads #1306

Closed espenak closed 2 months ago

espenak commented 2 months ago

The zipfile module has issues with S3 upload when the zipfile is large because it uses fp.tell() and gets wrong info because S3File chunks the underlying file. The easiest solution is using tarfile instead, and that should not be a problem since windows11, mac and linux all support tar.gz.

The switch is already done in c30d30287b0e87575473c94f39dc2c307c25d64c, but we need to:

espenak commented 2 months ago

Tests fixed in: d7788e4c273bc3ba6bcab309272fe7787c745463 Message fixed in: 9e093419b8f6a3fb4e732135ad95165ac28cdc5a

torgeirl commented 2 months ago

Minor bug: the archive extention is currently .zip.tar.gz, not .tar.gz..