search

devilry / trix2

Next generation Trix. Detailed task control and statistics app for better learning outcome.
BSD 3-Clause "New" or "Revised" License
2 stars 3 forks source link

Manual login step with updated `allauth` #117

Closed torgeirl closed 1 year ago

torgeirl commented 1 year ago

Updating Django 1.11 => 3.2 (#102) also bumps django-allauth 0.40 => =>0.51, and as part of that the login pattern suddenly includes an unnecessary manual step of conformation before being forwarded the login provider (you have to click «Continue»):

Screenshot from 2022-12-01 09-32-00

I guess we might have run into some backwards incompatible changes?

Levijatan commented 1 year ago

I am guessing that this might be caused by the SOCIALACCOUNT_LOGIN_ON_GET setting introduced inn 0.47, that is defaulted to false. So the user has to do a POST request to complete a login.

torgeirl commented 1 year ago

I am guessing that this might be caused by the SOCIALACCOUNT_LOGIN_ON_GET setting introduced inn 0.47, that is defaulted to false. So the user has to do a POST request to complete a login.

Adding SOCIALACCOUNT_LOGIN_ON_GET = True to settings solved it :+1: