Admins can't download statistics CSV files

devilry / trix2

Next generation Trix. Detailed task control and statistics app for better learning outcome.

BSD 3-Clause "New" or "Revised" License

2 stars 3 forks source link

Admins can't download statistics CSV files #156

Closed torgeirl closed 2 months ago

torgeirl commented 3 months ago

When an admin requests the CSV file of a course's statistics from /a/{COURSE-ID}/statistics/ascsv?tags={COURSE-TAG} they instead get a HTTP 403.

The check causing it (trix/trix_admin/views/statistics.py) doesn't seems to have changed recently so not sure why it stopped working, but my guess is the problem is caused by how the course tags are parsed.

torgeirl commented 2 months ago

The issue was caused by changes made to get_tags() (bac3ced01dcd5006225d3c93eb6ae52a8776fc1c) when optimizing the statistics page (#72).