devilry / trix2

Next generation Trix. Detailed task control and statistics app for better learning outcome.

BSD 3-Clause "New" or "Revised" License

2 stars 3 forks source link

Closed torgeirl closed 5 years ago

torgeirl commented 5 years ago

An if test for hidden assignments yields AttributeError: 'AnonymousUser' object has no attribute 'is_admin'.

It seems the error is non-critical and runs silent in the background so it shouldn't effect anonymous users' access to the service.

torgeirl commented 5 years ago

Suggested solution Make hidden=True the default, and set hidden=False iff user is authenticated and is_admin.

Elthan commented 5 years ago

Was this fixed by #81 ?

torgeirl commented 5 years ago

81 didn't fix it, and got reverted in #82 (seems I forgot to tag this issue when reverting).

Elthan commented 5 years ago

Unable to reproduce this error. _get_progress should never be called when a user is not logged in since it called by the AssignmentListProgressController which is not included unless the user is authenticated.

Are you still getting these errors?

torgeirl commented 5 years ago

@Elthan: we received the last error report yesterday; 45 reports over the last 30 days.