search

devinekask / generator-devine-boilerplate

⚙ the one and only devine.be boilerplate generator
23 stars 3 forks source link

react-devutils is installed even when react isn't selected #25

Closed thibmaek closed 7 years ago

thibmaek commented 7 years ago

Probably because there is no check of the if clause is closed to soon.

geoffreydhuyvetters commented 7 years ago

Has nothing to do with react, is needed for the error reporting window. Exported in the create-react-app monorepo.

I use for the custom webpackhotreload iFrame with the error messages

https://github.com/devinehowest/generator-devine-boilerplate/blob/master/generators/app/templates/webpack.config.js#L34

related: would love to implement this https://github.com/facebookincubator/create-react-app/pull/1101