devinit / DIwebsite-redesign

New DI website 2019
1 stars 1 forks source link

Feature | Short Publication Accessibility #1287

Closed davidebukali closed 1 year ago

davidebukali commented 1 year ago

Ticket #1285

davidebukali commented 1 year ago

@ThatcherK please find response to your feedback below

  1. Updated font size
  2. These are added by twitter analytics, we have no control over how they are rendered. I could add js to update the tag though seems like overkill.
  3. Words ending in ‘graphic’ are not allowed in alt text, renaming the image should clear the error. I removed the long desc attribute as its not well supported.
  4. Updated css for contrast errors
ThatcherK commented 1 year ago

Good job with the contrast errors! @davidebukali Just one alert I missed here, that can easily be resolved

Screenshot 2023-01-18 at 11 16 50
edwinmp commented 1 year ago

@davidebukali I hope this has covered every existing StreamField item for this page.

sonarcloud[bot] commented 1 year ago

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
12.5% 12.5% Duplication