search

devinit / DIwebsite-redesign

New DI website 2019
1 stars 1 forks source link

Feature | So What Boxes and Navigation to Interactive Charts #1309

Closed ThatcherK closed 1 year ago

ThatcherK commented 1 year ago

Ticket #1296

davidebukali commented 1 year ago

Looks good to me, also please look into Sonar cloud comment

ThatcherK commented 1 year ago

@davidebukali , I have looked at the sonar comments, but most if not all are complaining about duplication of help text in page fields, or field names, . This I can't do much in way of changing.... Unless in the future we get a way of configuring it not to complain about certain parts of the code?

davidebukali commented 1 year ago

@ThatcherK I agree that repeated strings could be a minor flag we can ignore here. There's also a security issue raised here. @edwinmp is it possible to disable some checks on sonar cloud

sonarcloud[bot] commented 1 year ago

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell D 135 Code Smells

No Coverage information No Coverage information
1.6% 1.6% Duplication