Closed akmiller01 closed 11 months ago
Stats of the last 30 days for DIwebsite-redesign: | User | Total reviews | Time to review | Total comments | |
---|---|---|---|---|---|
wakibi | 2 | 2d 5h 52m)) | 0 | ||
davidebukali | 1 | 17h 10m)) | 0 |
@akmiller01 great job here! Looks like the site will finally stop being slow. One question, why are we moving away from elastic search?
@akmiller01 great job here! Looks like the site will finally stop being slow. One question, why are we moving away from elastic search?
Thanks for reviewing, @ThatcherK ! Issues with ES are actually what first prompted this refactor. The ES index was periodically going missing, which was causing search pages to 500. Chris and I thought it might be a "Meow attack," but we couldn't find the vulnerability, so upgrading everything possible was the best course.
That, and it seems like ES might have been overkill for our needs. This psql based search seems to be just as fast, and reuses the dependency Wagtail needs anyway.
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
6.5% Duplication
⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.
Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.
🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | Secret | Commit | Filename | | | -------------- | ------------------------- | ---------------- | --------------- | -------------------- | | [5092469](https://dashboard.gitguardian.com/incidents/5092469?occurrence=112760406) | Google API Key | 71e56e4cd7c17ee4912c9c83c6ca187a84313fc1 | di_website/settings/base.py | [View secret](https://github.com/devinit/DIwebsite-redesign/commit/71e56e4cd7c17ee4912c9c83c6ca187a84313fc1#diff-18beae44fdec25ae6277096146b6b814b0277a656cf53bef91f12b0f8424247aL275) | | [5092469](https://dashboard.gitguardian.com/incidents/5092469?occurrence=113064594) | Google API Key | be2a6a91cb59723c755d3ae3f280718494580b70 | di_website/settings/base.py | [View secret](https://github.com/devinit/DIwebsite-redesign/commit/be2a6a91cb59723c755d3ae3f280718494580b70#diff-18beae44fdec25ae6277096146b6b814b0277a656cf53bef91f12b0f8424247aL243) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/detectors/specifics/googleaiza#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!