search

devinit / datahub-cms

A better organised version of https://github.com/devinit/digital-platform to act as a CMS for the Data Hub
0 stars 5 forks source link

Wrong and missing color values in budget levels reference file #7

Open epicallan opened 7 years ago

dw8547 commented 7 years ago

@epicallan, which reference file? (I.e., do you have a link to the file in the digital-platform repo? Might be able to help.

epicallan commented 7 years ago

Hi @dw8547 this is the link https://github.com/devinit/digital-platform/blob/master/reference/domestic-budget-level.csv thanks

dw8547 commented 7 years ago

Hi @epicallan, here is the info I have got so far:

What is domestic-budget-level.csv for?

domestic-budget-level.csv is a reference file for domestic.csv.

Originally, there were special characters in the level names in domestic-budget-level.csv that couldn't be used as HTML element ids (needed to run the visual). So this file was a mapping between the sluggified (special characters and spaces replaced with dashes) names and the original names.

What is the workflow here?

"Go to domestic.csv, draw the boxes using the level ids in domestic.csv, look-up an "un-sluggified" version of id in domestic-budget-level.csv to draw human-readable name on top of box."

And what do I do if the colour is missing from domestic-budget-level?

"The visual has some sort of default colour???"

epicallan commented 7 years ago

Hi @dw8547

Thanks for looking into this. What I want is for us to use colours from domestic-budget-level.csv instead of hard coded defaults ones within the app. I would prefer if we went a head and added the correct colour values in domestic-budget-level.csv at some point in the future.

dw8547 commented 7 years ago

@epicallan, not a problem. Let me know when you are ready to do this.