search

devinit / datahub

Datahub v2
http://data.devinit.org
15 stars 3 forks source link

Colour change for country profile international resource graphics #479

Closed jamesharle closed 5 years ago

jamesharle commented 5 years ago

I'm submitting a ...

Check one of the following options with "x" and add the appropriate label to the issue as well


[X] Bug report 
[ ] Regression (behaviour that used to work and stopped working in a new release)

Describe the Issue The How have resource inflows changed over time? graphic, located under the International Resources tab of Country Profiles, is off-brand.

Specifically, in the inflows over time graphic, we'd like the red #e8443a changed to the dark green #065139; the green #109e68 changed to the light green #92cba9; and the blue #0089cc changed to the green #109e68.

In the What's the mix of resources? graphic, we'd like

To Reproduce Replace the content below with the steps to reproduce the behaviour.

  1. Go to any country profile
  2. Click on the 'International Resources' tab.

Expected Behaviour We'd like this to be on-brand

Screenshots/GIF image

Desktop (please complete the following information):

Smartphone (please complete the following information):

Environment/Server:


- [X] Production
- [ ] Staging
- [ ] Test
- [ ] Development

Additional Context Add any other context about the problem here.

Requested Delivery Date: 30 January 2019

edwinmp commented 5 years ago

Hi @jamesharle ... you terminated your last sentence under "Describe the issue" halfway. Could you please complete that so I can implement it.

Also, you wanted the colour green #109e68 changed to the light green #92cba9. Unfortunately, the currently colour records have #5ab88a as light green and #b1d8bb as lighter green. Do you need me to change that? (it may affect more than one area of the DDH). Go here for the full list of colours.

jamesharle commented 5 years ago

Thanks @edwinmp - sorry for the malformed feedback there! I believe that no change is required to the second graphic in the end - initially I had wanted to change this to different shades of the same colour, but on closer examination I believe that the number of dimensions (types of finance) used here can sometimes be more than 5, in which case it's too hard to change it.

It would be better to use the #92cba9 green, so if you wouldn't mind replacing the current green in the first instance, that'd be great. I'm not sure why Allan would have used this green, perhaps there is a reason for it - but if we notice any issues we can always switch back.

edwinmp commented 5 years ago

@jamesharle this is the new look. If that's alright, will deploy it.

image

jamesharle commented 5 years ago

Perfect! Thanks E :)