devinit / datahub

Datahub v2
http://data.devinit.org
15 stars 3 forks source link

Bug on unbundling aid #488

Closed Duncan-Knox closed 5 years ago

Duncan-Knox commented 5 years ago

I'm submitting a ...

Check one of the following options with "x" and add the appropriate label to the issue as well


[] Bug report 
[X] Regression (behaviour that used to work and stopped working in a new release)

Describe the Issue Ordering of categories is inflexible when the user clicks through the treemap. Edit: unsure if related to this this issue, the category being moved by the user is the one that ends up showing first, I believe it was set-up to always show the category furthest left first, allowing others to be re-organised.

To Reproduce Replace the content below with the steps to reproduce the behaviour.

  1. Go to 'Unbundling and'
  2. Reorganise categories at top.
  3. Click through on the interactive treemap.
  4. See error - ordering does not change to reflect the categories.

Expected Behaviour It should be possible to click through the categories in the order they are shown at the top.

Screenshots/GIF If applicable, add screenshots or a GIF to help explain your problem. Ordering should

This GIF demonstrates the click through always follows the original ordering (to, from, sectors, forms, channels) of the categories and is not flexible. unbundling aid gif

In this second example. The click through should go from donor 'from' to recipient 'to' . However it jumps straight to sector. unbundling aid gif 2

Environment/Server:


- [X] Production
- [ ] Staging
- [ ] Test
- [ ] Development

Additional Context The first category on the left should be the one that shows on the first layer. The categories going right are the ones which show in-order as the treemap is clicked through. Have marked as a regression. Unsure exactly when this issue came into play.

Requested Delivery Date: when feasible given workload - to diagnose by end of next sprint if possible?

edwinmp commented 5 years ago

Hi @Duncan-Knox ... just deployed the fix for this on staging. Please test.

Duncan-Knox commented 5 years ago

Hi @edwinmp thanks for the update. The fix looks excellent. I've tested it out and it runs very smoothly.