devinit / ddw-analyst-ui

The Development Data Warehouse
http://ddw.devinit.org/
GNU General Public License v3.0
2 stars 1 forks source link

Use a configured base URL #962

Closed APIYOJENNIFER closed 1 year ago

APIYOJENNIFER commented 1 year ago

Issue #688

codecov-commenter commented 1 year ago

Codecov Report

Merging #962 (f1845a5) into develop (673f6d9) will increase coverage by 10.55%. The diff coverage is 100.00%.

:exclamation: Current head f1845a5 differs from pull request most recent head f00068b. Consider uploading reports for the commit f00068b to get more accurate results

@@             Coverage Diff              @@
##           develop     #962       +/-   ##
============================================
+ Coverage    46.33%   56.89%   +10.55%     
============================================
  Files          195      129       -66     
  Lines         7059     1965     -5094     
  Branches       522      491       -31     
============================================
- Hits          3271     1118     -2153     
+ Misses        3684      841     -2843     
+ Partials       104        6       -98     
Files Changed Coverage Δ
.../ScheduledEventsRunHistoryTableCard/utils/index.ts 41.17% <100.00%> (ø)
...components/ScheduledEventsTableCard/utils/index.ts 100.00% <100.00%> (ø)
.../components/ScheduledEventsTableRow/utils/index.ts 100.00% <100.00%> (ø)

... and 94 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

ThatcherK commented 1 year ago

@davidebukali can you test that this works, am unable to test on my end

davidebukali commented 1 year ago

@ThatcherK this works on my side with api base url set from .env file

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication