search

devinsays / options-framework-theme

An Options Panel Framework to help speed theme development.
http://wptheming.com/options-framework
GNU General Public License v2.0
754 stars 229 forks source link

Text Domains #183

Closed grappler closed 9 years ago

grappler commented 9 years ago

Hey Devin,

I was just doing a theme review and came across a place where you textdomain as the text domain. It was not the only place.

I saw that in other places you have used options-framework. Recently there was a new guidelines restricting theme authors to only have a maximum of two text domains.

How should theme authors translate the strings that are in the options framework?

devinsays commented 9 years ago

It should be "textdomain" all across. I'll review the code and update any that aren't correct.

Users should find/replace "textdomain" with their own textdomain slug when they are bundling the framework and want translation to work.

grappler commented 9 years ago

What about theme-textdomain?

devinsays commented 9 years ago

I just quickly scanned through this, and I didn't see any strings that used "optionsframework". It looked they all correctly had "textdomain". Would you mind the ones out? Or perhaps the version you were reviewing was out-of-date or edited by that developer?

grappler commented 9 years ago

Sure, here is one https://github.com/devinsays/options-framework-theme/blob/master/inc/includes/class-options-sanitization.php#L316

devinsays commented 9 years ago

Ah, thanks! I grepped for the wrong string.

devinsays commented 9 years ago

Reopen if you see any I missed. Thanks!