search

devinsays / portfolio-press

A WordPress theme for artists and designers to showcase their work.
https://wptheming.com/portfolio-theme/
GNU General Public License v2.0
62 stars 30 forks source link

Logo option is not dependant on Options Framework plugin being installed. #56

Closed mfields closed 10 years ago

mfields commented 10 years ago

Here's what I did:

  1. Installed Options Framework.
  2. Set a logo.
  3. Uninstalled Options Framework.
  4. Visited the site.

At this point I would expect the logo to revert to the Site Title and Tagline, however it persists. What do you think about having the logo disappear when the plugin is not activated?

devinsays commented 10 years ago

I could see arguments for both cases. If someone accidentally disabled the plugin- they might still expect their site to stay the same.

But it is an issue because they wouldn't be able to easily change those options if the plugin was no longer available.

devinsays commented 10 years ago

I am going to close this ticket as wontfix. I haven't had any questions or problems with this the last few years- so I don't want to change the function and possibly cause issues.

Also, the theme review will likely require me to bundle the Options Framework when I submit (rather than load as a plugin) so it will be a non-issue.