devinsheppy / classicimmunities

classic immunities main repo
GNU General Public License v2.0
0 stars 2 forks source link

doesn't work #1

Closed Alessandro-Barbieri closed 4 months ago

Alessandro-Barbieri commented 4 months ago

Version 0.0.4 WoW classic SoD

I polymorphed a wolf (ID 2959) and the tooltip says that it's polymorph immune

devinsheppy commented 4 months ago

Hi, thanks for submitting an issue!

Just had a quick look myself at that same mob and it isn't showing a polymorph immunity for me.

I doubled checked the database to make sure that NPC ID wasn't in by mistake and I don't see it there either.

Screenshot 2024-04-17 163746

Are you able to attach a screenshot of what you see on your end?

Alessandro-Barbieri commented 4 months ago

Screenshot_20240418_000336

Alessandro-Barbieri commented 4 months ago

There is atleast a localization issue with UnitCreatureType return value see https://wowpedia.fandom.com/wiki/API_UnitCreatureType

devinsheppy commented 4 months ago

Yep, I see now how that would cause issues with everything.

Thanks for the update I will look into a solution.

Alessandro-Barbieri commented 4 months ago

There is an useful library here https://www.wowace.com/projects/libbabble-creaturetype-3-0

devinsheppy commented 4 months ago

Should be fixed with the 0.0.7 version.

Thanks for helping fix this issue!

Let me know if there are any other problems.