Can you update the version in hex.pm?

GeraldXv commented 5 years ago

Hi devinus, As I found the 1.5.2 is available in the GitHub releases, can you update it in the hex.pm?

getong commented 5 years ago

see #109

Vagabond commented 5 years ago

Done!

onno-vos-dev commented 5 years ago

@Vagabond I'm trying to update top 1.5.2 (not using HEX) but it appears to me that the commits in 1.5.2 are dangling and don't have a corresponding branch that it refers to.

Did you by any chance manage to push the tag but not the corresponding branch it's based off?

Vagabond commented 5 years ago

^andrew@system76:: git clone https://github.com/devinus/poolboy                         
Cloning into 'poolboy'...                                                                                                     
remote: Enumerating objects: 1, done.                                                                                         
remote: Counting objects: 100% (1/1), done.                                                                                   
remote: Total 1001 (delta 0), reused 0 (delta 0), pack-reused 1000                                                            
Receiving objects: 100% (1001/1001), 3.27 MiB | 6.47 MiB/s, done.                                                             
Resolving deltas: 100% (491/491), done.                                                                                       
^andrew@system76:: cd poolboy                        
^andrew@system76:: git checkout 1.5.2                        
Note: checking out '1.5.2'.                                                                                                   

You are in 'detached HEAD' state. You can look around, make experimental                                                      
changes and commit them, and you can discard any commits you make in this                                                     
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at 29be47d Roll 1.5.2
^andrew@system76:: make
===> Verifying dependencies...
===> Compiling poolboy

I'm not sure what you mean?

onno-vos-dev commented 5 years ago

@Vagabond Looking into this again it appears that I needed more coffee yesterday. I could swear that the commits that were in 1.5.2 were not found in master but it appears I'm wrong. Sorry to disturb you :)

Vagabond commented 5 years ago

No problem, better to be safe than sorry.

devinus / poolboy

Can you update the version in hex.pm? #116