search

deviprasad135 / CAS741

Other
0 stars 0 forks source link

Comments for VnV one: #12

Closed MaXiaoye closed 6 years ago

MaXiaoye commented 7 years ago

Hi Devi,

I am away from linear algebra for years. (I learned it in undergraduate stage) So if my comments are unprofessional then please do not consider and just correct me. I would like to provide more comments from structure perspective. :)

Issue One: In System test section, I think it is better to test for different input. Especially test cases for different kinds of invalid inputs. The software should show some error message to user and describe valid input format correspondingly.

Best Regards, Marshall

deviprasad135 commented 6 years ago

Thanks for the issue. I have tested for singular matrix for which it will show its a singular matrix no solution. If I give some invalid input the software do not even accept the input.