devitocodes / devito

DSL and compiler framework for automated finite-differences and stencil computation
http://www.devitoproject.org
MIT License
557 stars 226 forks source link

types: Remove increments from SubDimension names #2257

Closed EdCaunt closed 10 months ago

EdCaunt commented 11 months ago

Requires a compiler pass to resolve clashing dimension names, which in turn requires additions to uxreplace so it can be used on ConditionalDimensions.

codecov[bot] commented 11 months ago

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (dd1b154) 86.90% compared to head (6eeb17b) 86.96%. Report is 74 commits behind head on master.

Files Patch % Lines
devito/symbolics/manipulation.py 94.33% 3 Missing :warning:
devito/ir/equations/algorithms.py 96.55% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2257 +/- ## ========================================== + Coverage 86.90% 86.96% +0.06% ========================================== Files 229 229 Lines 41545 42262 +717 Branches 7660 7809 +149 ========================================== + Hits 36105 36755 +650 - Misses 4818 4860 +42 - Partials 622 647 +25 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

review-notebook-app[bot] commented 10 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

EdCaunt commented 10 months ago

Superseded by #2269