search

devitocodes / devito

DSL and compiler framework for automated finite-differences and stencil computation
http://www.devitoproject.org
MIT License
537 stars 221 forks source link

compiler: Add pass to abridge SubDimension names where possible #2269

Closed EdCaunt closed 7 months ago

EdCaunt commented 7 months ago

Making the PR to run it through CI and get some opinions. Still needs tests and probably the option to pass a keyword argument to Operator along the lines of shorten_subdims=False (lmk if anyone has a snappier name).

codecov[bot] commented 7 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (1b5f8c3) 86.82% compared to head (0d00ecd) 86.83%.

Files Patch % Lines
devito/types/grid.py 87.50% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2269 +/- ## ========================================== + Coverage 86.82% 86.83% +0.01% ========================================== Files 229 229 Lines 42387 42435 +48 Branches 7845 7868 +23 ========================================== + Hits 36803 36850 +47 - Misses 4924 4926 +2 + Partials 660 659 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

review-notebook-app[bot] commented 7 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB