search

devitocodes / devito

DSL and compiler framework for automated finite-differences and stencil computation
http://www.devitoproject.org
MIT License
557 stars 225 forks source link

Correct the Poisson equation in the cavity flow example #2308

Closed rafael-fuente closed 7 months ago

rafael-fuente commented 7 months ago

There is a sign mistake in the Poisson equation. It doesn't significantly affect the solution of this particular example, but it can be important when solving Navier Stokes for other problems.

review-notebook-app[bot] commented 7 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

mloubout commented 7 months ago

Good catch, thanks!

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (8c86bc2) 86.71% compared to head (f68c098) 86.71%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2308 +/- ## ======================================= Coverage 86.71% 86.71% ======================================= Files 229 229 Lines 42958 42958 Branches 7958 7958 ======================================= + Hits 37251 37253 +2 + Misses 5023 5021 -2 Partials 684 684 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.