examples: Add an example notebook for ADER-FD schemes

devitocodes / devito

DSL and compiler framework for automated finite-differences and stencil computation

http://www.devitoproject.org

MIT License

557 stars 225 forks source link

examples: Add an example notebook for ADER-FD schemes #2338

Closed EdCaunt closed 4 months ago

EdCaunt commented 6 months ago

Currently work in progress. Adds a notebook showing how to solve the first-order formulation of the acoustic wave equation with 4th-order ADER timestepping.

Lmk your thoughts.

review-notebook-app[bot] commented 6 months ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.76%. Comparing base (fcfdfa3) to head (50be3f8).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #2338 +/- ## ======================================= Coverage 86.76% 86.76% ======================================= Files 233 233 Lines 43740 43740 Branches 8075 8075 ======================================= Hits 37952 37952 Misses 5079 5079 Partials 709 709 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rhodrin commented 5 months ago

What's the reason this is currently located in misc vs the seismic tutorials?

Locating in the later and referring previous tutorials where appropriate would seem more suitable to me?

rhodrin commented 5 months ago

Still need to check the mathematical details in some places.

But in general, throughout the tutorial recommend expanding and clarifying statements a little more and adding a comparison vs staggered acoustic.

mloubout commented 4 months ago

Mostly minor comments. Neess reabase as well.